Vesync Switch for Display #37334
Vesync Switch for Display #37334
Conversation
…e-assistant#37322) Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) from 0.5.11801 to 0.5.11805. - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet-runtime dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…37321) Bumps [parser](https://github.com/whitequark/parser) from 3.3.7.0 to 3.3.7.1. - [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md) - [Commits](whitequark/parser@v3.3.7.0...v3.3.7.1) --- updated-dependencies: - dependency-name: parser dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…t#37324) * When downloading from backup page, backup is decrypted * Update source/_includes/common-tasks/backups.md Co-authored-by: Franck Nijhof <git@frenck.dev> --------- Co-authored-by: Franck Nijhof <git@frenck.dev>
* Storing emergency kit: clarify steps * Apply parallelism
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates several documentation files. The backups documents now describe on‐the‐fly decryption during download and provide clearer guidance on encryption key management. The footer and redirects files have adjustments to social media links, including the addition of a Bluesky link and updated line breaks. Integration documentation for Reolink now marks certain number entities with a plus sign to indicate push update support (with an adjustment for the day/night mode entity), and VeSync documentation introduces a new “display” attribute for switch sections. Changes
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
source/more-info/backup-emergency-kit.markdown (3)
26-28: Reword and clarify encryption key instructions.
The added bullet points (lines 26–28) clearly explain that Home Assistant tracks the current encryption key and that if the key has been changed, the old key is still required for restoring older backups. Consider rephrasing line 27 to remove the phrase “in the meantime” (e.g., “- But if you have changed the encryption key, you still need the old key that matches previous backups.”) for enhanced clarity and conciseness.🧰 Tools
🪛 LanguageTool
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
43-44: Enhance key retrieval instructions.
The added lines (43–44) explain that if the user still has access to their Home Assistant instance, the encryption key can be re-downloaded from the backup settings. To further assist the reader, consider adding a direct link or reference to the backup settings page.
45-46: Standardize language for clarity.
In line 46, please update “can not” to “cannot” for a more standard and concise expression. Additionally, reformatting the bullet points for parallel structure might improve readability, for example:
- If you have not changed the encryption key: Home Assistant retains it and decrypts the backup on the fly.
- If you have changed the encryption key: Home Assistant cannot decrypt the backup on the fly, so you need the corresponding encryption key.
🧰 Tools
🪛 LanguageTool
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...ed the encryption key**: Home Assistant can not decrypt it on the fly. You need the enc...(CAN_NOT_PREMIUM)
source/_integrations/vesync.markdown (1)
138-138: Remove extra blank line.Remove one of the consecutive blank lines to maintain consistent formatting.
| `child_lock` | The current status of the child lock (Core200S/300s/400s) | off | - - + ## Humidifier🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
138-138: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
Gemfile.lockis excluded by!**/*.locksource/images/dashboards/history_graph.pngis excluded by!**/*.pngsource/images/dashboards/history_graph_lines.pngis excluded by!**/*.png
📒 Files selected for processing (6)
source/_includes/common-tasks/backups.md(1 hunks)source/_includes/site/footer.html(1 hunks)source/_integrations/reolink.markdown(2 hunks)source/_integrations/vesync.markdown(3 hunks)source/_redirects(1 hunks)source/more-info/backup-emergency-kit.markdown(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- source/_includes/common-tasks/backups.md
🧰 Additional context used
📓 Path-based instructions (6)
`*/**(html|markdown|md)`: - For instructional content in doc...
*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
source/_redirects
`*/**(html|markdown|md)`: - Use bold to mark UI strings. - I...
*/**(html|markdown|md): - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
source/_redirects
`*/**(html|markdown|md)`: - Be brief in your replies and don...
*/**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
source/_redirects
`*/**(html|markdown|md)`: - Use sentence-style capitalizatio...
*/**(html|markdown|md): - Use sentence-style capitalization also in headings.
source/_redirects
`*/**(html|markdown|md)`: do not comment on HTML used for ic...
*/**(html|markdown|md): do not comment on HTML used for icons
source/_redirects
`*/**(html|markdown|md)`: Avoid flagging inline HTML for emb...
*/**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.
source/_redirects
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/vesync.markdown
138-138: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
🪛 LanguageTool
source/more-info/backup-emergency-kit.markdown
[style] ~27-~27: ‘in the meantime’ might be wordy. Consider a shorter alternative.
Context: ... if you have changed the encryption key in the meantime, you still need the old key that matche...
(EN_WORDINESS_PREMIUM_IN_THE_MEANTIME)
[style] ~46-~46: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...ed the encryption key**: Home Assistant can not decrypt it on the fly. You need the enc...
(CAN_NOT_PREMIUM)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Lint Text
🔇 Additional comments (5)
source/more-info/backup-emergency-kit.markdown (1)
38-38: Step clarity and numbering consistency.
The newly added step (line 38) instructs users on how to generate a new encryption key. The numbering is consistent with the previous steps and the instruction is clear.source/_redirects (1)
12-13: LGTM!The new redirects for Mastodon and Bluesky are correctly configured.
source/_includes/site/footer.html (1)
88-88: LGTM!The line breaks improve readability, and the Bluesky social media link is properly configured with the correct attributes.
Also applies to: 95-100, 107-107
source/_integrations/vesync.markdown (1)
120-122: LGTM!The display switch attribute is properly documented for both Power & energy sensors and Humidifier sections.
Also applies to: 151-153
source/_integrations/reolink.markdown (1)
142-146: LGTM!The plus (+) sign is correctly added to indicate push update support for image-related number entities, and the day night mode select entity is properly updated.
Also applies to: 192-192
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Thank you for contributing, @cdnninja 👍
|
|
Closing to replace with: #38830 |
home-assistant/core#137493
Proposed change
home-assistant/core#137493
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit
New Features
Documentation