-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add S3 #37771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S3 #37771
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughA new markdown file has been introduced to document the S3 integration for Home Assistant backups. This file includes setup instructions, metadata, configuration parameters (Access Key ID, Secret Access Key, Bucket Name, and Endpoint URL), and guidance on removing the integration. It also highlights compatibility with S3-compatible services such as Minio. Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/s3.markdown
(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: home-assistant.io Test
source/_integrations/s3.markdown
[error] 30-30: Incorrect usage of the term: “docs”, use “documentation” instead terminology
🔇 Additional comments (5)
source/_integrations/s3.markdown (5)
1-13
: Metadata Block VerificationThe front matter metadata is complete and follows Home Assistant’s documentation standards. All required fields (title, description, ha_release, ha_category, ha_iot_class, ha_config_flow, ha_domain, ha_codeowners, ha_integration_type) are provided and correctly formatted.
15-18
: Integration OverviewThe introductory text clearly describes the purpose of the integration and mentions that both AWS S3 and S3-compatible services (e.g., Minio) are supported. This provides useful context for users.
20-20
: Config Flow InclusionThe inclusion of the standard Config Flow documentation via the
{% include integrations/config_flow.md %}
tag is correct and ensures consistency across integrations.
22-31
: Configuration Parameters BlockThe configuration block is well-organized, with each parameter clearly listed alongside its description. This helps users understand the required setup details for the integration.
🧰 Tools
🪛 GitHub Actions: home-assistant.io Test
[error] 30-30: Incorrect usage of the term: “docs”, use “documentation” instead terminology
33-37
: Removal Instructions ClarityThe "Removing the integration" section is concise and correctly indicates that standard removal procedures apply. Including the
{% include integrations/remove_device_service.md %}
tag provides users with appropriate guidance.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tomasbedrich 👍
Proposed change
Add docs for a new S3 integration.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit