Clarification for a moron ;) #3797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Often it helps to see the syntax for configuration variables...
fabaff
requested changes
Oct 27, 2017
| @@ -22,6 +22,9 @@ To enable this sensor, add the following lines to your `configuration.yaml`: | |||
| # Example configuration.yaml entry | |||
| sensor: | |||
| - platform: uptime | |||
| #Optional configuration variables | |||
There was a problem hiding this comment.
We try to keep all configuration samples minimal. Thus, no optional requirement in the default sample. This helps user to get started quickly by copy-&-paste the sample without worrying about optional parameters which they most likely not need. If required, insert a full configuration sample later that covers special setups or alike.
|
Yes. That makes perfect sense.
--
Get the Boomerang Email App <http://boomerangapp.com/mobile> on your phone
----------
On Thu, Oct 26, 2017 at 10:37 PM, Fabian Affolter <notifications@github.com> wrote:
*@fabaff* requested changes on this pull request.
------------------------------
In source/_components/sensor.uptime.markdown
<#3797 (comment)>
:
@@ -22,6 +22,9 @@ To enable this sensor, add the following lines to your `configuration.yaml`:
# Example configuration.yaml entry
sensor:
- platform: uptime
+ #Optional configuration variables
We try to keep all configuration samples minimal. Thus, no optional
requirement in the default sample. This helps user to get started quickly
by copy-&-paste the sample without worrying about optional parameters which
they most likely not need. If required, insert a full configuration sample
later that covers special setups or alike.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3797 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AekVUneI-ZO6MiK4ia_eC82rK50TGABIks5swWv8gaJpZM4QIiKk>
.
|
fabaff
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often it helps to see the syntax for configuration variables...
Description:
I added the configuration variables to the example after testing the config. I'm still new at this and seeing how variables are used in YAML syntax in the examples helps me learn.
Pull request in home-assistant (if applicable): home-assistant/home-assistant#