Skip to content

Add alternative install instructions for ProxmoxVE #37997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Mar 15, 2025

Proposed change

This adds alternative installation instructions to install HAOS as VM on the popular Proxmox Virtual Environment.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Introduced a new "ProxmoxVE" section in the installation guide for Home Assistant Operating System.
    • Provides detailed steps for setting up a virtual machine using ProxmoxVE, including image preparation, VM creation, configuration, and optional device passthrough.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Mar 15, 2025
Copy link

netlify bot commented Mar 15, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 3130ffe
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67d6bdb5f710a9000807bb7f
😎 Deploy Preview https://deploy-preview-37997--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Mar 15, 2025

📝 Walkthrough

Walkthrough

The changes introduce a new "ProxmoxVE" section to the Home Assistant Operating System installation guide. This section provides comprehensive instructions for setting up a virtual machine on Proxmox Virtual Environment. It includes steps for downloading and decompressing the HAOS image, creating a VM with specified CPU and memory, importing the disk image, and configuring hardware settings through the Proxmox WebUI. Additionally, optional guidance for adding network and USB passthrough is provided, while the existing KVM (virt-manager) instructions remain unchanged.

Changes

File Change Summary
source/_includes/.../operating_system.md Added a new "ProxmoxVE" section with step-by-step instructions for setting up Home Assistant OS on ProxmoxVE, covering image preparation, VM creation, disk import, hardware configuration, and optional network/USB passthrough.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant P as Proxmox WebUI
    participant VM as Virtual Machine

    U->>U: Download & decompress HAOS image
    U->>P: Initiate VM creation with CPU & memory settings
    U->>P: Import the decompressed HAOS disk image into VM storage
    P->>VM: Configure VM hardware (disk settings)
    alt Optional Configurations
        P->>VM: Add network interface and USB devices for passthrough
    end
    Note over VM: VM ready for Home Assistant OS installation
Loading

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
source/_includes/installation/operating_system.md (4)

357-360: Clarity in ProxmoxVE Section Header
The new "ProxmoxVE" section is clearly added and well-organized, aligning with the documentation improvement objectives. Consider rephrasing the phrase “to a local folder storage” to “to a local storage folder” for improved readability.


387-392: Grammar and Tense Consistency for Disk Import Step
The instruction “Import the downloaded and decompressed HAOS image into the VM storage of your choice and deleted the downloaded image afterwards” would read better as “...and delete the downloaded image afterward.” This revision maintains present tense consistency and follows American English conventions.

🧰 Tools
🪛 LanguageTool

[locale-violation] ~387-~387: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ...choice and deleted the downloaded image afterwards. ```bash qm importdi...

(AFTERWARDS_US)


401-406: Activation Instructions: Minor Hyphenation Correction
The activation step is well described. Note a minor improvement: change “if your storage is SSD based” to “if your storage is SSD-based” to ensure proper hyphenation in American English.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~404-~404: The adjective “SSD-based” is spelled with a hyphen.
Context: ...d click on Add (*if your storage is SSD based, then enable the SSD emulation unde...

(BASED_HYPHEN)


407-411: Typographical Correction in Network Device Step
There is a small typo in the network device step: “The network device is no attached as Network Device (net0)” should be corrected to “is not attached.” This change will improve clarity and grammatical correctness.

🧰 Tools
🪛 LanguageTool

[misspelling] ~410-~410: Did you mean “not”?
Context: ...Model** 4. The network device is no attached as Network Device (net0) t...

(NO_NOT)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9aec73 and 651f4f9.

📒 Files selected for processing (1)
  • source/_includes/installation/operating_system.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_includes/installation/operating_system.md

[locale-violation] ~387-~387: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ...choice and deleted the downloaded image afterwards. ```bash qm importdi...

(AFTERWARDS_US)


[uncategorized] ~404-~404: The adjective “SSD-based” is spelled with a hyphen.
Context: ...d click on Add (*if your storage is SSD based, then enable the SSD emulation unde...

(BASED_HYPHEN)


[misspelling] ~410-~410: Did you mean “not”?
Context: ...Model** 4. The network device is no attached as Network Device (net0) t...

(NO_NOT)

🔇 Additional comments (6)
source/_includes/installation/operating_system.md (6)

361-365: Clear Download Instructions
The command block provides clear, step-by-step instructions for downloading and decompressing the HAOS image. Ensure that placeholder values such as <PATH-TO-LOCAL-STORAGE>, <URL>, and <COMPRESSED-IMAGE> are documented or explained elsewhere for consistency.


367-373: Exemplary Download Command Block
The example snippet effectively demonstrates the intended usage with real values, making it easier for users to understand the process.


375-380: VM Creation Command Clarity
The instructions and the associated qm create command are clear and follow ProxmoxVE best practices. The use of placeholders like <CPU-CORES>, <MEMORY-IN-MB>, <VM-NAME>, and <VMID> is appropriate, providing guidance for customization.


381-386: Effective Example for VM Creation
The provided example command, complete with specific values (e.g., --cores 2, --memory 4096, etc.), is very helpful for users to see a concrete illustration of the VM creation process.


394-400: Clear Example for Disk Import
The example command that demonstrates how to import the disk image is clear and instructive, reinforcing the written instructions effectively.


412-416: USB Passthrough Instructions are Clear
The detailed instructions for adding USB devices for passthrough are concise and consistent with the rest of the guide. No changes are necessary here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
source/_includes/installation/operating_system.md (2)

357-416: New ProxmoxVE Section: Clear and Detailed Guidance

The added ProxmoxVE tab now provides a thorough, step‑by‑step guide for setting up Home Assistant OS on ProxmoxVE. The instructions—including downloading the image, creating a new VM (with free <VMID>), importing the disk image, and configuring both storage and network devices—are clear and practical. Using embedded bash code blocks further enhances the clarity for users performing these tasks.

(Optionally, consider adding a brief note or link to Proxmox documentation regarding VMID selection and storage configuration to further assist less experienced users.)

🧰 Tools
🪛 LanguageTool

[locale-violation] ~387-~387: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ... choice and delete the downloaded image afterwards. ```bash qm importdi...

(AFTERWARDS_US)


387-390: American English Consistency: Replace "afterwards" with "afterward"

In the instruction text:

"Import the downloaded and decompressed HAOS image into the VM storage of your choice and delete the downloaded image afterwards."

For consistency with American English conventions (as flagged by static analysis), please change "afterwards" to "afterward."

Proposed Diff:

-... and delete the downloaded image afterwards.
+... and delete the downloaded image afterward.
🧰 Tools
🪛 LanguageTool

[locale-violation] ~387-~387: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ... choice and delete the downloaded image afterwards. ```bash qm importdi...

(AFTERWARDS_US)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 651f4f9 and 3130ffe.

📒 Files selected for processing (1)
  • source/_includes/installation/operating_system.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_includes/installation/operating_system.md

[locale-violation] ~387-~387: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ... choice and delete the downloaded image afterwards. ```bash qm importdi...

(AFTERWARDS_US)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our ADR doesn't support this yet. We have limited the docs instructions through the supported ADRs.

Please stay tuned, as I will open a proposal to change these (including adding proxmox support) this week.

Once that is approved, we can re-consider/re-open this one 👍

../Frenck

@frenck frenck closed this Mar 16, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Documentation PRs Mar 16, 2025
@mib1185
Copy link
Contributor Author

mib1185 commented Mar 16, 2025

ok, will have my 👀 open for this ADR 😬

@mib1185 mib1185 reopened this Mar 16, 2025
@github-project-automation github-project-automation bot moved this from Done to Todo in Documentation PRs Mar 16, 2025
@mib1185 mib1185 closed this Mar 16, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Documentation PRs Mar 16, 2025
@mib1185
Copy link
Contributor Author

mib1185 commented Mar 16, 2025

We will provide documentation for the following systems build on top of these technologies:

  • Proxmox (KVM/QEMU based)
  • Unraid (KVM/QEMU based)
  • VirtualBox
  • VMWare

sourc: https://github.com/home-assistant/architecture/blob/master/adr/0015-home-assistant-os.md#supported-hypervisors

I think we already support ProxmoxVE official 🤔 🙈

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants