Cambridge Audio add control bus text #38109
Conversation
- Pre-Amp - Control Bus
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes update the Cambridge Audio integration documentation by introducing a new configuration entity called Control Bus mode. This mode allows the network player to control a connected power amplifier through increase and decrease commands, bypassing Pre-Amp mode which is documented separately. The documentation now explains the limitations of Control Bus mode and provides details on the functionality and role of Pre-Amp mode in volume control. Changes
Sequence Diagram(s)sequenceDiagram
participant HA as Home Assistant
participant CAP as Cambridge Audio Player
participant PA as Power Amplifier
HA->>CAP: Send volume increase/decrease command
CAP->>PA: Forward full volume signal (Control Bus mode enabled)
sequenceDiagram
participant HA as Home Assistant
participant CAP as Cambridge Audio Player
participant Pre as Pre-Amplifier
HA->>CAP: Send volume control command
CAP->>Pre: Adjust volume via Pre-Amp mode
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/cambridge_audio.markdown (2)
73-75: Typographical & Markdown Formatting Issues in the Pre-Amp SectionThere is a typographical error in the Pre-Amp section: the phrase "Home Home Assistant" on line 74 contains a duplicated word. Additionally, consider adding blank lines above and below the "### Pre-Amp" heading to satisfy markdown style guidelines.
Apply this diff:
-When Pre-Amp mode is enabled, Home Home Assistant can control the output volume of your Pre-Amplifier. +When Pre-Amp mode is enabled, Home Assistant can control the output volume of your Pre-Amplifier.🧰 Tools
🪛 LanguageTool
[duplication] ~74-~74: Possible typo: you repeated a word.
Context: ...# Pre-Amp When Pre-Amp mode is enabled, Home Home Assistant can control the output volume...(ENGLISH_WORD_REPEAT_RULE)
🪛 markdownlint-cli2 (0.17.2)
73-73: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
74-74: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
76-77: Resolve Typos and Enhance Clarity in the Control Bus SectionThere are multiple issues in the Control Bus section:
- "ebabled" should be corrected to "enabled".
- "metwork player" should be corrected to "network player".
- A comma after the introductory phrase "In this case" would improve readability.
Apply this diff:
-When Control Bus mode is ebabled, Home Assistant can control the output volume of your Power Amplifier when it is connected to a Cambridge Audio network player using the Control Bus interface. In this case Pre-Amp mode can be disabled, the metwork player will send the signal with full volume to the power amplifier and the volume of the power amplifier can be controlled using volume up and down controls. Control Bus does not support setting the volume to a certain value, it can only increase and decrease the current volume. +When Control Bus mode is enabled, Home Assistant can control the output volume of your Power Amplifier when it is connected to a Cambridge Audio network player using the Control Bus interface. In this case, Pre-Amp mode can be disabled, the network player will send the signal at full volume to the power amplifier, and the amplifier’s volume can be controlled using volume up and down controls. Control Bus does not support setting the volume to a specific value; it can only increase or decrease the current volume.🧰 Tools
🪛 LanguageTool
[formatting] ~77-~77: Consider inserting a comma after an introductory phrase for better readability.
Context: ...player using the Control Bus interface. In this case Pre-Amp mode can be disabled, the metwo...(IN_THAT_CASE_COMMA)
[uncategorized] ~77-~77: You might be missing the article “the” here.
Context: ...lled using volume up and down controls. Control Bus does not support setting the volume...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 markdownlint-cli2 (0.17.2)
76-76: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/cambridge_audio.markdown(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/cambridge_audio.markdown
[duplication] ~74-~74: Possible typo: you repeated a word.
Context: ...# Pre-Amp When Pre-Amp mode is enabled, Home Home Assistant can control the output volume...
(ENGLISH_WORD_REPEAT_RULE)
[formatting] ~77-~77: Consider inserting a comma after an introductory phrase for better readability.
Context: ...player using the Control Bus interface. In this case Pre-Amp mode can be disabled, the metwo...
(IN_THAT_CASE_COMMA)
[uncategorized] ~77-~77: You might be missing the article “the” here.
Context: ...lled using volume up and down controls. Control Bus does not support setting the volume...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/cambridge_audio.markdown
73-73: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
74-74: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
76-76: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🔇 Additional comments (1)
source/_integrations/cambridge_audio.markdown (1)
71-72: New Configuration Entity Added: Control Bus modeThe new entity "Control Bus mode" is clearly added to the list of available configuration entities. Please ensure that its functionality is fully documented and that any related configuration or testing updates are completed as needed.
Co-authored-by: Simon Lamon <32477463+silamon@users.noreply.github.com>
Co-authored-by: Simon Lamon <32477463+silamon@users.noreply.github.com>
|
@silamon Lol yeah thank you for the corrections. I had eye surgery done and am very light sensitive at the moment, so I spent the least time possible looking at the screen. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/cambridge_audio.markdown (2)
73-75: Markdown Formatting for Headings
The Pre-Amp section header and its accompanying description would benefit from having blank lines before and after the heading to satisfy markdown lint rules (MD022). In addition, please ensure there are no trailing spaces (MD009) at the end of the description line.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
73-73: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
74-74: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
76-77: Punctuation and Formatting in New Section
For the Control Bus section, please insert a comma after the introductory phrase "In this case" to improve readability. The sentence should read:"In this case, Pre-Amp mode can be disabled..."
In addition, add blank lines around the header to address markdown lint warnings.🧰 Tools
🪛 LanguageTool
[formatting] ~77-~77: Consider inserting a comma after an introductory phrase for better readability.
Context: ...player using the Control Bus interface. In this case Pre-Amp mode can be disabled, the netwo...(IN_THAT_CASE_COMMA)
[uncategorized] ~77-~77: You might be missing the article “the” here.
Context: ...lled using volume up and down controls. Control Bus does not support setting the volume...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 markdownlint-cli2 (0.17.2)
76-76: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/cambridge_audio.markdown(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/cambridge_audio.markdown
[formatting] ~77-~77: Consider inserting a comma after an introductory phrase for better readability.
Context: ...player using the Control Bus interface. In this case Pre-Amp mode can be disabled, the netwo...
(IN_THAT_CASE_COMMA)
[uncategorized] ~77-~77: You might be missing the article “the” here.
Context: ...lled using volume up and down controls. Control Bus does not support setting the volume...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/cambridge_audio.markdown
73-73: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
74-74: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
76-76: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🔇 Additional comments (1)
source/_integrations/cambridge_audio.markdown (1)
71-71: Entity Addition Consistency
The new list entry for Control Bus mode has been added consistently with the other configuration entities. Please verify that its naming and formatting align with the overall documentation standards.
|
Awaits parent means this will be merged when home-assistant/core#139131 is merged I guess? |
Proposed change
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit
New Features
Documentation