-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update roborock docs with routines #38459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The feature was already released |
📝 WalkthroughWalkthroughThe change updates the Roborock integration documentation. It amends the data fetching description by clarifying that both map data and routines are now retrieved via the cloud. Additionally, it introduces information about button entities; the documentation now explains that some vacuums allow routines to be configured through the app and that a button entity will be created for each routine. There were no changes made to declared public or exported entities. Changes
Sequence Diagram(s)sequenceDiagram
participant User as App User
participant Int as Roborock Integration
participant Cloud as Cloud Service
User->>Int: Request vacuum integration info
Int->>Cloud: Fetch map data and routines
Cloud-->>Int: Return map data and routines
Note right of Int: Create button entities for each routine
User->>Int: Tap button entity to trigger routine
Int->>Cloud: Execute routine command
Cloud-->>Int: Send confirmation
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/roborock.markdown (1)
106-107
: Clarify Cloud Data Retrieval and Trim Trailing Whitespaces
The updated line now clearly indicates that both map data and routines are fetched through the cloud, which aligns with the PR objective of restoring routine information in the documentation. Note that a trailing whitespace was detected on this line (as flagged by markdownlint). Please remove the trailing space for consistency with the style guidelines.-Map data and routines are always fetched through the cloud, and Dyad and Zeo devices are cloud only. +Map data and routines are always fetched through the cloud, and Dyad and Zeo devices are cloud only.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
106-106: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/roborock.markdown
(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/roborock.markdown
106-106: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/roborock.markdown (1)
253-254
: Document Button Entities for Routines
The newly added sentence effectively informs users that some vacuums allow routines to be set up via the app, with a dedicated button entity created to trigger each routine. This addition resolves the missing information regarding routine control as outlined in the PR objectives.
Thank you @regevbr appreciate the follow through on this! |
* Update roborock docs with routines * Update roborock.markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @regevbr 👍
Proposed change
#37817 changes somehow got lost. This adds back the new routine control docs
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit