Skip to content

Add template function: device_name #38476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Add template function: device_name #38476

merged 1 commit into from
Apr 14, 2025

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Apr 10, 2025

Proposed change

Add template function: device_name

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Enhanced templating documentation with a new device naming feature.
    • Provided examples on retrieving a device's name using either a device or entity identifier.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 10, 2025
Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit e965b5c
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67f7f67ba04c7400089eaa32
😎 Deploy Preview https://deploy-preview-38476--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 10, 2025

📝 Walkthrough

Walkthrough

The changes update the templating documentation by introducing a new function, device_name(lookup_value), which returns the device name based on either a device ID or an entity ID. The documentation now includes examples demonstrating its usage as both a function and a filter. Additionally, the declarations for exported or public entities have been updated to include this new method, with the changes integrated into the existing devices section without altering the overall structure.

Changes

File(s) Change Summary
source/_docs/configuration/templating.markdown Added documentation for the new device_name(lookup_value) function, including usage examples and updated public entity declarations.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TemplatingEngine as Engine
    participant DeviceNameFunction as device_name
    participant DeviceRegistry as Registry

    User->>Engine: Submit template with device_name(lookup_value)
    Engine->>device_name: Invoke device_name(lookup_value)
    device_name->>Registry: Look up device details using lookup_value
    Registry-->>device_name: Return device information
    device_name-->>Engine: Return device name
    Engine-->>User: Render template with device name
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_docs/configuration/templating.markdown (1)

430-431: Improve Documentation Sentence Structure for device_name
The current description reads as two separate fragments. For improved clarity and consistency with similar entries, consider revising it to:

- `device_name(lookup_value)` returns the device name for a given device ID or entity ID. Can also be used as a filter.
+ `device_name(lookup_value)` returns the device name for a given device ID or entity ID and can also be used as a filter.

This change addresses the static analysis hint to include a complete sentence with a clear subject.

🧰 Tools
🪛 LanguageTool

[style] ~430-~430: To form a complete sentence, be sure to include a subject.
Context: ...ame for a given device ID or entity ID. Can also be used as a filter. #### Devices...

(MISSING_IT_THERE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ae6407 and e965b5c.

📒 Files selected for processing (1)
  • source/_docs/configuration/templating.markdown (2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_docs/configuration/templating.markdown

[style] ~430-~430: To form a complete sentence, be sure to include a subject.
Context: ...ame for a given device ID or entity ID. Can also be used as a filter. #### Devices...

(MISSING_IT_THERE)

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @piitaya 👍

@github-project-automation github-project-automation bot moved this from Todo to Approved in Documentation PRs Apr 11, 2025
@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Apr 11, 2025
@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Apr 14, 2025
@frenck frenck merged commit 1a67539 into next Apr 14, 2025
9 checks passed
@frenck frenck deleted the device_name_template branch April 14, 2025 12:30
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Apr 14, 2025
@github-project-automation github-project-automation bot moved this from Approved to Done in Documentation PRs Apr 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants