-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
2025.4.2 #38493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2025.4.2 #38493
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis update increments the Home Assistant patch version and revises the release date in the configuration. Additionally, new release notes for patch version 2025.4.2 have been added, consolidating various fixes and enhancements. The release notes detail dependency bumps, improved error handling in the remote calendar flow, checks for the existence of the Roborock map before updates, and the introduction of new configuration options and sensor classes. Changes
Sequence Diagram(s)sequenceDiagram
participant HA as Home Assistant
participant RC as Remote Calendar Service
participant Logger
HA->>RC: Request calendar update
alt Successful Response
RC-->>HA: Updated calendar data
else Error Occurs
RC-->>HA: Error details
HA->>Logger: Log error details
end
sequenceDiagram
participant RI as Roborock Integration
participant RM as Map Checker
participant Logger
RI->>RM: Verify current map existence
alt Map exists
RI->>RM: Update map state
else Map missing
RI->>Logger: Log warning/error message
end
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_posts/2025-04-02-release-20254.markdown (1)
626-634
: Markdown Link References Cleanup (Optional):
Static analysis flags several duplicate or unused reference definitions (e.g. “#141505”, “#142299”, “@IvanLH”, “@Lash-L”, etc.). While these may be false positives depending on how reference linking is used in the document, consider cleaning them up to improve overall markdown quality and eliminate warnings from markdownlint.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
626-626: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#141505"(MD053, link-image-reference-definitions)
629-629: Link and image reference definitions should be needed
Unused link or image reference definition: "#142299"(MD053, link-image-reference-definitions)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
_config.yml
(1 hunks)source/_posts/2025-04-02-release-20254.markdown
(2 hunks)source/changelogs/core-2025.4.markdown
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/changelogs/core-2025.4.markdown
1068-1068: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#141505"
(MD053, link-image-reference-definitions)
1071-1071: Link and image reference definitions should be needed
Unused link or image reference definition: "#142299"
(MD053, link-image-reference-definitions)
1115-1115: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@IvanLH"
(MD053, link-image-reference-definitions)
1123-1123: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bdraco"
(MD053, link-image-reference-definitions)
1125-1125: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bramkragten"
(MD053, link-image-reference-definitions)
1126-1126: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@chemelli74"
(MD053, link-image-reference-definitions)
1128-1128: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@fredrike"
(MD053, link-image-reference-definitions)
1129-1129: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
1132-1132: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@joostlek"
(MD053, link-image-reference-definitions)
1134-1134: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@marcelveldt"
(MD053, link-image-reference-definitions)
1136-1136: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@puddly"
(MD053, link-image-reference-definitions)
source/_posts/2025-04-02-release-20254.markdown
626-626: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#141505"
(MD053, link-image-reference-definitions)
629-629: Link and image reference definitions should be needed
Unused link or image reference definition: "#142299"
(MD053, link-image-reference-definitions)
673-673: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@IvanLH"
(MD053, link-image-reference-definitions)
675-675: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@Lash-L"
(MD053, link-image-reference-definitions)
677-677: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@Thomas55555"
(MD053, link-image-reference-definitions)
680-680: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@andrewsayre"
(MD053, link-image-reference-definitions)
681-681: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bdraco"
(MD053, link-image-reference-definitions)
682-682: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bieniu"
(MD053, link-image-reference-definitions)
683-683: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bramkragten"
(MD053, link-image-reference-definitions)
684-684: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@chemelli74"
(MD053, link-image-reference-definitions)
686-686: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@fredrike"
(MD053, link-image-reference-definitions)
687-687: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
689-689: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@jbouwh"
(MD053, link-image-reference-definitions)
690-690: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@joostlek"
(MD053, link-image-reference-definitions)
692-692: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@marcelveldt"
(MD053, link-image-reference-definitions)
693-693: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@mib1185"
(MD053, link-image-reference-definitions)
694-694: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@puddly"
(MD053, link-image-reference-definitions)
695-695: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"
(MD053, link-image-reference-definitions)
697-697: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tronikos"
(MD053, link-image-reference-definitions)
🔇 Additional comments (4)
_config.yml (1)
109-112
: Update Release Configuration Values:
The patch update is reflected by raising thecurrent_patch_version
to 2 and updating thedate_released
to "2025-04-11". This well‐aligns with the new release schedule. Please double‐check that all related documentation is synchronized with these configuration changes.source/changelogs/core-2025.4.markdown (1)
1021-1066
: Patch Release Changelog – 2025.4.2 Details:
The new changelog block for the patch release 2025.4.2 is comprehensive and properly attributes the contributions. A couple of suggestions:
• There is a typo in the entry “Check that the current roboorck map exists before updating it.” (line ~1027); it should be corrected to “roborock”.
• Two later entries bump the opower library—first to 0.10.0 (line ~1025) and then to 0.11.1 (line ~1033). Please verify that this sequence is intentional and accurately reflects the intended dependency updates.Overall, the entries are clear and correctly formatted with proper issue references and contributor attributions.
source/_posts/2025-04-02-release-20254.markdown (2)
72-73
: Navigation Update for Patch Releases:
The table of contents now correctly includes a link for the new patch release – “2025.4.2 - April 11”. Please ensure the anchor (#202542---april-11
) exactly matches the header later in the document for consistent navigation.
579-625
: Detailed Patch Release Section – 2025.4.2:
This newly added section enumerates the changes comprehensively. In addition to the points noted in the changelog review:
• Please fix the typo “roboorck” to “roborock” in the corresponding bullet.
• The dual entries for upgrading opower (first to 0.10.0 then later to 0.11.1) should be verified to ensure they represent the intended incremental update.Overall, the patch release notes are informative and provide valuable context for users upgrading Home Assistant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/changelogs/core-2025.4.markdown (1)
1027-1027
: Typo in Roborock Reference
At line 1027 the text reads “Check that the current roboorck map exists before updating it.” A simple typo should be fixed to “Roborock”.- Check that the current roboorck map exists before updating it. + Check that the current Roborock map exists before updating it.source/_posts/2025-04-02-release-20254.markdown (2)
628-632
: Optional: Cleanup of Duplicate Markdown Link References
Static analysis flags many duplicate link/image reference definitions (e.g. for “#141505”, “@IvanLH”, “@Lash-L”, etc.). Although they do not affect functionality, cleaning them up would improve maintainability and readability of the file.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
628-628: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#141505"(MD053, link-image-reference-definitions)
632-632: Link and image reference definitions should be needed
Unused link or image reference definition: "#142299"(MD053, link-image-reference-definitions)
700-702
: Optional: Remove Redundant Link References
Similar to the above, there are duplicate link reference definitions (e.g. for “@tronikos” and others) that appear to be repeated. If these duplicates are not required by your markdown flavor or build tooling, consider consolidating them to reduce clutter.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
700-700: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"(MD053, link-image-reference-definitions)
702-702: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tronikos"(MD053, link-image-reference-definitions)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
_config.yml
(1 hunks)source/_posts/2025-04-02-release-20254.markdown
(2 hunks)source/changelogs/core-2025.4.markdown
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- _config.yml
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_posts/2025-04-02-release-20254.markdown
72-72: Link fragments should be valid
null
(MD051, link-fragments)
628-628: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#141505"
(MD053, link-image-reference-definitions)
632-632: Link and image reference definitions should be needed
Unused link or image reference definition: "#142299"
(MD053, link-image-reference-definitions)
677-677: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@IvanLH"
(MD053, link-image-reference-definitions)
679-679: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@Lash-L"
(MD053, link-image-reference-definitions)
681-681: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@Thomas55555"
(MD053, link-image-reference-definitions)
684-684: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@andrewsayre"
(MD053, link-image-reference-definitions)
685-685: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bdraco"
(MD053, link-image-reference-definitions)
686-686: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bieniu"
(MD053, link-image-reference-definitions)
687-687: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bramkragten"
(MD053, link-image-reference-definitions)
688-688: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@chemelli74"
(MD053, link-image-reference-definitions)
690-690: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@fredrike"
(MD053, link-image-reference-definitions)
691-691: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
693-693: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@jbouwh"
(MD053, link-image-reference-definitions)
694-694: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@joostlek"
(MD053, link-image-reference-definitions)
696-696: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@marcelveldt"
(MD053, link-image-reference-definitions)
697-697: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@mib1185"
(MD053, link-image-reference-definitions)
698-698: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@puddly"
(MD053, link-image-reference-definitions)
699-699: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@sanjay900"
(MD053, link-image-reference-definitions)
700-700: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@starkillerOG"
(MD053, link-image-reference-definitions)
702-702: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@tronikos"
(MD053, link-image-reference-definitions)
source/changelogs/core-2025.4.markdown
1070-1070: Link and image reference definitions should be needed
Duplicate link or image reference definition: "#141505"
(MD053, link-image-reference-definitions)
1074-1074: Link and image reference definitions should be needed
Unused link or image reference definition: "#142299"
(MD053, link-image-reference-definitions)
1119-1119: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@IvanLH"
(MD053, link-image-reference-definitions)
1127-1127: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bdraco"
(MD053, link-image-reference-definitions)
1129-1129: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@bramkragten"
(MD053, link-image-reference-definitions)
1130-1130: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@chemelli74"
(MD053, link-image-reference-definitions)
1132-1132: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@fredrike"
(MD053, link-image-reference-definitions)
1133-1133: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@frenck"
(MD053, link-image-reference-definitions)
1136-1136: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@joostlek"
(MD053, link-image-reference-definitions)
1138-1138: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@marcelveldt"
(MD053, link-image-reference-definitions)
1140-1140: Link and image reference definitions should be needed
Duplicate link or image reference definition: "@puddly"
(MD053, link-image-reference-definitions)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (6)
source/changelogs/core-2025.4.markdown (4)
72-72
: Inconsistent Release Date in Patch Release Link
In the list at line 72 the patch release “2025.4.2” is shown with the date “April 11” (i.e. “- 2025.4.2 - April 11”), but the detailed section header at line 1021 says “2025.4.2 – April 12”. Please verify which date is correct and update both places for consistency.
1021-1021
: Title for New Patch Release
The section header “## Release 2025.4.2 - April 12” clearly sets the intended release date. Once the link label is fixed (see above), this header looks correct and aligns with the PR objective of updating the patch release notes.
1025-1033
: Duplicate opower Bump Items
Two items mention updating opower: one “Bump opower to 0.10.0” at line 1025 and another “Bump opower to 0.11.1” at line 1033. According to the release summary the intended update is to version 0.11.1. Please verify whether 0.10.0 is an interim step that should be removed or if the items need consolidation so that only the final opower bump is listed.
1021-1068
: Overall Patch Release Details for 2025.4.2
All the list items in this new patch release section from line 1021 through 1068 cover a wide range of dependency bumps, additional error handling and fixes – from remote calendar flow improvements to integration-specific tweaks. Aside from the two points mentioned above (the inconsistent date and duplicate opower updates), the descriptions are clear and correspond with the PR objectives.source/_posts/2025-04-02-release-20254.markdown (2)
72-72
: Mismatch in Patch Release Navigation Date
In the patch releases navigation at line 72 the link for “2025.4.2” shows the date as “April 11” while the detailed section later (line 579+) uses “April 12”. For consistency across the document and with the changelog file, please update the navigation link so that the correct date appears consistently.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
72-72: Link fragments should be valid
null(MD051, link-fragments)
579-593
: Detailed Patch Release Section for 2025.4.2
The new “### 2025.4.2 - April 12” section (starting around line 579) lists all the fixes and updates in a clear bullet‐point format. The items mirror those in the changelog. Aside from the issues already noted in the changelog review, this section reads well and reflects the intended improvements.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Proposed change
Release notes for home-assistant/core#142755
Summary by CodeRabbit