-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add number platform to eheimdigital #38504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes update the EHEIM Digital integration documentation by introducing a new "Number" category. This category is now included in both the Changes
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/eheimdigital.markdown (2)
54-57
: New 'Number' Section for Temperature Offsets:
This new section under the EHEIM thermocontrol+e heading clearly outlines the temperature offset features—both for the standard and night settings. You might consider adding a brief example or clarification on ideal offset ranges to enhance user understanding.
61-65
: New 'Number' Section for Pump Speed Settings:
The added Number section for the EHEIM classicVARIO+e integration effectively documents the pump speed settings across different modes. For additional clarity, consider outlining the expected range or units for these speed settings if applicable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/eheimdigital.markdown
(3 hunks)
🔇 Additional comments (2)
source/_integrations/eheimdigital.markdown (2)
7-7
: Addition of 'Number' in ha_category:
The new entryNumber
in theha_category
list clearly communicates that the integration now supports numerical controls. Please ensure that this aligns with Home Assistant’s documentation schema for categories.
19-19
: Addition of 'number' in ha_platforms:
Includingnumber
in theha_platforms
section is consistent with the naming conventions (using lowercase) and accurately reflects the new feature support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
This adds the number platform to eheimdigital.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit