Skip to content

Clarify what OS:es are supported and not #38513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Clarify what OS:es are supported and not #38513

merged 2 commits into from
Apr 14, 2025

Conversation

lellky
Copy link
Contributor

@lellky lellky commented Apr 13, 2025 •
edited by coderabbitai bot
Loading

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Refined the phrasing in the Home Assistant Supervised installation instructions to enhance clarity regarding supported operating systems by removing redundant wording and adjusting punctuation.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Apr 13, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 13, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 5b54fd6
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67fcb5d990e2120008c7c9fd
😎 Deploy Preview https://deploy-preview-38513--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 13, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This change updates the installation instructions for Home Assistant Supervised. The revision adjusts the phrasing in the second step by removing the word “only” and modifying the punctuation. This alteration maintains the intended meaning—that Debian is supported while Ubuntu, Armbian, and Raspberry Pi OS are not—but presents the information with updated wording.

Changes

File Change Summary
source/_includes/installation/supervised.md Revised phrasing in the second installation step: removed “only” and adjusted punctuation to clarify that Debian is supported while Ubuntu, Armbian, and Raspberry Pi OS are not.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af0de04 and 5b54fd6.

📒 Files selected for processing (1)
  • source/_includes/installation/supervised.md (1 hunks)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 13, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_includes/installation/supervised.md (1)

13-13: Remove trailing whitespace

Line 13 contains trailing whitespace per the markdownlint MD009 warning. Removing the extra space will help maintain consistency with markdown style guidelines.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

13-13: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3434cc and af0de04.

📒 Files selected for processing (1)
  • source/_includes/installation/supervised.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_includes/installation/supervised.md

13-13: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

🔇 Additional comments (1)
source/_includes/installation/supervised.md (1)

12-14: Clarify the removal of "only" from the OS support statement

The PR description indicates that the word "only" should be removed for clarity; however, line 12 still reads "it only supports Debian". Please verify that this wording aligns with your intended revision for clearer documentation.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

13-13: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

c0ffeeca7
c0ffeeca7 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lellky 👍

@github-project-automation github-project-automation bot moved this from Todo to Approved in Documentation PRs Apr 14, 2025
@c0ffeeca7 c0ffeeca7 enabled auto-merge (squash) April 14, 2025 07:14
@c0ffeeca7 c0ffeeca7 merged commit f37bc0d into home-assistant:current Apr 14, 2025
5 of 7 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Documentation PRs Apr 14, 2025
@lellky
Copy link
Contributor Author

lellky commented Apr 14, 2025

Thank you, @lellky 👍

No. Thank you @c0ffeeca7 ! 👍 This confused me so much yesterday when I was reading the docs 😕

@c0ffeeca7
Copy link
Contributor

Thank you, @lellky 👍

No. Thank you @c0ffeeca7 ! 👍 This confused me so much yesterday when I was reading the docs 😕

haha, yes. I can totally see how this phrasing can be confusing.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
No open projects
Documentation PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lellky @c0ffeeca7