-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Remove legacy format exception for ESPHome entity naming #38559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe ESPHome documentation was updated to clarify how entity names and IDs are generated based on the presence or absence of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ESPHome_Config
participant Documentation
User ->> Documentation: Reads about entity naming
Documentation ->> ESPHome_Config: Describes naming logic
alt friendly_name is set
ESPHome_Config ->> User: Entity name = friendly_name + component name
ESPHome_Config ->> User: Entity ID = device name prefix + entity name
else friendly_name is not set
ESPHome_Config ->> User: Entity name = device name + component name
ESPHome_Config ->> User: Entity ID = device name prefix + component name
end
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
We have had an exception for the legacy naming scheme when friendly name is unset. As ESPHome is working to reach bronze quality scale, remove the exception.
quality scale pr: home-assistant/core#143033
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit