Skip to content

Remove legacy format exception for ESPHome entity naming #38559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 15, 2025

Proposed change

We have had an exception for the legacy naming scheme when friendly name is unset. As ESPHome is working to reach bronze quality scale, remove the exception.

quality scale pr: home-assistant/core#143033

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Clarified how ESPHome entity names and IDs are generated, merging previous sections and updating examples for improved understanding. Removed outdated legacy naming information.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 15, 2025
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 65c83d0
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67fecbdf9fb9290008dfddb4
😎 Deploy Preview https://deploy-preview-38559--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 15, 2025

📝 Walkthrough

Walkthrough

The ESPHome documentation was updated to clarify how entity names and IDs are generated based on the presence or absence of the friendly_name field in the configuration. The previous separation between "friendly naming" and "legacy naming" was removed, and the rules were unified into a single explanation. The documentation now states that the entity name is a combination of the friendly_name (or name if friendly_name is not set) and the component name, while the entity ID is derived from this entity name with the device name as a prefix. Examples were updated to reflect this unified naming approach.

Changes

File(s) Summary of Changes
source/_integrations/esphome.markdown Revised documentation to unify and clarify entity naming and ID rules; removed legacy naming section; updated naming examples

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ESPHome_Config
    participant Documentation

    User ->> Documentation: Reads about entity naming
    Documentation ->> ESPHome_Config: Describes naming logic
    alt friendly_name is set
        ESPHome_Config ->> User: Entity name = friendly_name + component name
        ESPHome_Config ->> User: Entity ID = device name prefix + entity name
    else friendly_name is not set
        ESPHome_Config ->> User: Entity name = device name + component name
        ESPHome_Config ->> User: Entity ID = device name prefix + component name
    end
Loading

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e8e6cc and 65c83d0.

📒 Files selected for processing (1)
  • source/_integrations/esphome.markdown (3 hunks)
🔇 Additional comments (1)
source/_integrations/esphome.markdown (1)

61-88: Documentation update is clear, accurate, and aligns with ESPHome's new naming rules.

The unified explanation for entity naming and IDs is concise and removes ambiguity. The updated examples accurately reflect the new behavior, and the removal of the legacy naming section is appropriate for bronze quality scale compliance.

No further changes needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Apr 15, 2025
@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Apr 19, 2025
@frenck frenck merged commit 46be8fb into next Apr 19, 2025
9 checks passed
@frenck frenck deleted the bdraco-patch-9 branch April 19, 2025 10:41
@home-assistant home-assistant bot removed parent-merged The parent PR has been merged already awaits-parent Awaits the merge of an parent PR labels Apr 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants