Skip to content

Fix alert spacing issues #38569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Fix alert spacing issues #38569

merged 2 commits into from
Apr 16, 2025

Conversation

mrdarrengriffin
Copy link
Contributor

@mrdarrengriffin mrdarrengriffin commented Apr 16, 2025 •
edited by coderabbitai bot
Loading

Proposed change

Fixes instances where margins double up and make inconsistent spacing for alerts. Also tidied up the SCSS file

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Style
    • Improved alert styling for better consistency and spacing by adjusting margin and padding rules.
    • Ensured the last element inside alerts no longer has unnecessary bottom margin.
    • No visual changes to alert colors or overall appearance.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Apr 16, 2025
@mrdarrengriffin mrdarrengriffin marked this pull request as ready for review April 16, 2025 09:46
@netlify Netlify
Copy link

netlify bot commented Apr 16, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 225c1df
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67ff7c8603447e0007c6044b
😎 Deploy Preview https://deploy-preview-38569--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 16, 2025

📝 Walkthrough

Walkthrough

The changes reorganize and refine the SCSS styling for alert components. Property orders within the alert container and its variants are adjusted for consistency, and a new selector ensures the last child within an alert does not have a bottom margin. The margin removal for paragraph elements is also updated, and background color declarations for alert variants are repositioned within their respective blocks. No color values or other style properties are altered.

Changes

File(s) Change Summary
sass/homeassistant/plugins/_alert.scss Reordered CSS properties for div.alert and alert variants; added selector to remove bottom margin from last child; removed margin-bottom: 0px from p; moved background-color to top of variant blocks.

Sequence Diagram(s)

No sequence diagram is necessary for these style-only changes.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c277ec5 and 225c1df.

📒 Files selected for processing (1)
  • sass/homeassistant/plugins/_alert.scss (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (4)
sass/homeassistant/plugins/_alert.scss (4)

4-6: Property reordering improves clarity.

Reordering margin-bottom, padding, and position at the top of the block makes the SCSS more readable and maintainable.

8-10: Addition of last-child selector prevents doubled margins.

The new > *:last-of-type { margin-bottom: 0; } selector is a best practice for eliminating unwanted extra space after the last child, directly addressing the doubled margin issue.

12-21: Removal of blanket paragraph margin reset increases precision.

By removing margin-bottom: 0px from the p selector, only the last child element's margin is affected, which is more precise and avoids unintended side effects on all paragraphs.

24-61: Moving background-color to the top of each alert variant block is a style improvement.

This change improves code organization and readability without affecting the rendered result.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck merged commit 9a1d317 into current Apr 16, 2025
9 checks passed
@frenck frenck deleted the alert-spacing-fix branch April 16, 2025 10:26
bramkragten
bramkragten reviewed Apr 16, 2025
View reviewed changes
sass/homeassistant/plugins/_alert.scss
padding: 20px 24px 20px 24px;
position: relative;

>*:last-of-type {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda agree with Paulus here, you want to use :last-child here I think?

@mrdarrengriffin mrdarrengriffin restored the alert-spacing-fix branch April 16, 2025 11:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bramkragten bramkragten bramkragten left review comments

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrdarrengriffin @frenck @bramkragten