Skip to content

Add binary sensor to miele integration #38590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2025

Conversation

astrandb
Copy link
Contributor

@astrandb astrandb commented Apr 17, 2025

Proposed change

Add examples on implemented binary sensors

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the Miele integration documentation to include support for binary sensors.
    • Added detailed descriptions of six supported binary sensor types.
    • Clarified product range terminology and expanded guidance on entity availability.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 17, 2025
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 65b4ae2
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/680bc813b595a500084c873b
😎 Deploy Preview https://deploy-preview-38590--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 17, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

"""

Walkthrough

The documentation for the Miele integration was updated to reflect the inclusion of "binary_sensor" as a supported platform and category. The description of Miele's product range was corrected, and the guidance on entity availability was expanded to recommend consulting product manuals. A new section was added, detailing six types of binary sensors supported by the integration, each with a brief description.

Changes

File Change Summary
source/_integrations/miele.markdown Added "binary_sensor" to supported platforms and categories; corrected product range wording; expanded note on entity availability; added detailed section describing supported binary sensors.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation
    User ->> Documentation: Reads Miele integration docs
    Documentation -->> User: Shows supported platforms (including binary_sensor)
    Documentation -->> User: Displays binary sensor types and descriptions
    User ->> Documentation: Checks entity availability note
    Documentation -->> User: Advises to consult product manual for details
Loading

"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a21cfc and 65b4ae2.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (4 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)

83-94: Document supported binary sensors and fix verb agreement
The new section comprehensively lists all supported binary sensor entities. Minor nit: adjust verb agreement in descriptions for plural "appliances."

@@ -89,7 +89,7 @@
-  - **Full remote control**: Signals the state of Full remote control feature on appliances that supports it.
+  - **Full remote control**: Signals the state of Full remote control feature on appliances that support it.

@@ -90,7 +90,7 @@
-  - **Mobile start**: Signals the state of Mobile start feature on appliances that supports it.
+  - **Mobile start**: Signals the state of Mobile start feature on appliances that support it.

@@ -93,7 +93,7 @@
-  - **Smart grid**: Signals the state of Smart grid feature on appliances that supports it.
+  - **Smart grid**: Signals the state of Smart grid feature on appliances that support it.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~93-~93: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...f Smart grid feature on appliances that supports it. {% enddetails %} ### Sensor {% de...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e588b51 and c69135c.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown

[uncategorized] ~93-~93: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...f Smart grid feature on appliances that supports it. {% enddetails %} ### Sensor {% de...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (4)
source/_integrations/miele.markdown (4)

5-5: Add Binary sensor to integration categories
Adding "Binary sensor" under ha_category ensures the integration appears in the binary sensor documentation and aligns with the newly implemented feature.


15-15: Add binary_sensor to supported platforms
Including binary_sensor under ha_platforms makes the new platform available for configuration, matching the actual implementation in the core integration.


22-22: Correct Miele product description
Updating from "floorcare" to "floor care" improves readability and consistency in describing Miele’s appliance categories.


78-78: Enhance entity availability note
The expanded note clearly highlights that feature availability varies by model/generation and directs users to consult the product manual for specifics, reducing potential user confusion.

c0ffeeca7
c0ffeeca7 previously approved these changes Apr 17, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @astrandb 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Apr 17, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
source/_integrations/miele.markdown (3)

87-87: Remove redundant “Operation state” bullet
The top-level “Operation state” entry is unnecessary here and duplicates the section title. Removing it will streamline the list of binary sensors.

- - **Operation state**:

89-89: Fix article and verb agreement in Full remote control description
Add the missing article and correct the verb to plural for consistency.

-  - **Full remote control**: Shows the state of Full remote control feature on appliances that supports it.
+  - **Full remote control**: Shows the state of the Full remote control feature on appliances that support it.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~89-~89: You might be missing the article “the” here.
Context: ...ll remote control**: Shows the state of Full remote control feature on appliances th...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


93-93: Fix article and verb agreement in Smart grid description
Add the missing article and adjust the verb form for grammatical accuracy.

-  - **Smart grid**: Shows the state of Smart grid feature on appliances that supports it.
+  - **Smart grid**: Shows the state of the Smart grid feature on appliances that support it.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~93-~93: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...f Smart grid feature on appliances that supports it. {% enddetails %} ### Sensor {% de...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c69135c and 5a21cfc.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/miele.markdown

[uncategorized] ~89-~89: You might be missing the article “the” here.
Context: ...ll remote control**: Shows the state of Full remote control feature on appliances th...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~93-~93: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...f Smart grid feature on appliances that supports it. {% enddetails %} ### Sensor {% de...

(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (5)
source/_integrations/miele.markdown (5)

5-5: Added binary_sensor to documentation categories
Including "Binary sensor" under ha_category aligns the metadata with the new feature and ensures it shows up correctly in the Home Assistant docs.


15-15: Included binary_sensor in supported platforms
Adding binary_sensor to ha_platforms accurately reflects the integration’s capabilities after the new feature merge.


22-22: Corrected product range wording
Changing "floorcare" to "floor care" improves readability and aligns with standard terminology.


78-78: Expanded note to reference product manuals
The added sentence directs users to consult their appliance manual for implementation details—a valuable clarification.


83-83: Added “Binary sensor” section header
Introducing the ### Binary sensor heading cleanly segregates the binary sensor details under supported functionality.

@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Apr 25, 2025
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict

@home-assistant home-assistant bot marked this pull request as draft April 25, 2025 17:32
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@c0ffeeca7 c0ffeeca7 marked this pull request as ready for review April 27, 2025 06:58
@home-assistant home-assistant bot requested a review from joostlek April 27, 2025 06:58
@c0ffeeca7 c0ffeeca7 merged commit a1a5fdc into home-assistant:next Apr 27, 2025
7 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Apr 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants