-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add diagnostics platform to miele page #38591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe Miele integration metadata was updated to include the "diagnostics" platform in its list of supported Home Assistant platforms. Previously, only the "sensor" platform was listed. This change reflects that the integration now supports diagnostics entities or features in addition to sensors. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant MieleIntegration
User->>HomeAssistant: Loads Miele integration
HomeAssistant->>MieleIntegration: Initialize platforms (sensor, diagnostics)
MieleIntegration-->>HomeAssistant: Registers sensor and diagnostics entities
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)
13-16
: Add a documentation section for diagnostics
Whilediagnostics
is now declared as a supported platform, there isn’t a corresponding section under "Supported functionality" explaining what diagnostic entities are available or how to configure them. Consider adding a new "Diagnostics" subsection (mirroring the existing "Sensor" section) that describes the diagnostics platform, lists available entities, and provides usage examples.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/miele.markdown
(1 hunks)
🔇 Additional comments (1)
source/_integrations/miele.markdown (1)
13-16
: Platform list updated to include diagnostics
Theha_platforms
entry correctly addsdiagnostics
alongsidesensor
, and the list remains sorted alphabetically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @astrandb 👍
Proposed change
SSIA
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit