-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Adjusted incorrect information for switchbot docs #38593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted incorrect information for switchbot docs #38593
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the SwitchBot integration was updated to describe a shift from a polling-based status update mechanism to a local push-based approach. The revised text explains that SwitchBot devices now push state changes to Home Assistant in real time, and that when users perform actions, the integration fetches the latest status immediately. The note regarding the use of a local connection, without reliance on the SwitchBot Cloud, remains unchanged. Changes
Sequence Diagram(s)sequenceDiagram
participant SwitchBot Device
participant Home Assistant
Note over SwitchBot Device,Home Assistant: Real-time device state update (push-based)
SwitchBot Device->>Home Assistant: Push state change
Note over Home Assistant,SwitchBot Device: User initiates action via Home Assistant
Home Assistant->>SwitchBot Device: Send action command
SwitchBot Device-->>Home Assistant: Execute action
Home Assistant->>SwitchBot Device: Fetch latest status
SwitchBot Device-->>Home Assistant: Return updated status
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/switchbot.markdown (1)
419-420
: Improve consistency and clarity in the “Data updates” section
- The term “local_push” includes unexpected zero‑width spaces and doesn’t match the metadata above (
ha_iot_class: Local Push
). Consider using Local Push (or wraplocal_push
in backticks) without extra spaces for consistency.- The phrase “without going via the SwitchBot Cloud” is slightly awkward. A clearer alternative might be:
The integration connects directly to devices over Bluetooth without using the SwitchBot Cloud.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/switchbot.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, @zerzhang 👍
* fix description for data updates * tiny tweak --------- Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Proposed change
Adjust the description for switchbot data updates
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit