-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Document required manual inputs for ESPHome new entry config flow #38612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Warning Rate limit exceeded@bdraco has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 45 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation for the ESPHome integration was updated by adding a new section called "Required manual input." This section outlines the configuration parameters that must be manually provided when setting up an ESPHome device, including detailed descriptions for each parameter and a reference link to the official ESPHome Native API documentation. No changes were made to the codebase or public interfaces. Changes
Sequence Diagram(s)No sequence diagram is generated since the changes are limited to documentation updates. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
source/_integrations/esphome.markdown (5)
53-54
: Consistent section heading formatting
The heading “Required manual Input” uses inconsistent capitalization. It would be clearer and more consistent with other Home Assistant docs to use either title case or sentence case, and recommend pluralizing if multiple entries are required.- ### Required manual Input + ### Required manual inputs
55-57
: Use active voice for the introductory sentence
The phrase “The configuration of an ESPHome device requires you to…” is wordy. A more direct, active-voice construction will improve readability.- The configuration of an ESPHome device requires you to enter the following information: + To configure an ESPHome device, enter the following information:
59-62
: Mention the default API port for clarity
Readers may not know the default port for the ESPHome native API. Including it here will save them a lookup.host: description: "IP address or hostname of the ESPHome device. <br> This will be pre-filled if the device was auto-discovered." -port: - description: "Port used by the ESPHome native API. <br> This will be pre-filled if the device was auto-discovered." +port: + description: "Port used by the ESPHome native API (default: 6053). <br> This will be pre-filled if the device was auto-discovered."
63-64
: Link to noise PSK generation documentation
It may not be obvious how to generate or retrieve a 32‑byte base64 Noise PSK. Consider linking to ESPHome’s encryption guide for end-to-end clarity.-noise_psk: - description: "The pre-shared key used for encryption. <br> This is a 32-byte base64-encoded string. Leave this blank if native encryption is not enabled." +noise_psk: + description: "The pre-shared key used for encryption. <br> This is a 32‑byte base64‑encoded string. Leave blank if native encryption is not enabled. See [Noise encryption in ESPHome](https://esphome.io/guides/security.html#noise-encryption) for more details."
65-66
: Clarify deprecation of the password field
The current note is helpful but could be streamlined. You might also indicate the version when password support will be removed, if known.-password: - description: "Device password. <br> Note: Passwords are deprecated—use encryption keys instead." +password: + description: "Device password (deprecated). <br> Use a Noise PSK (encryption key) instead – password support will be removed in a future release."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/esphome.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
@coderabbitai please provide commitable inline suggestion comments for the nitpick comments |
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed:
Length of output: 346 🏁 Script executed:
Length of output: 14916 🏁 Script executed:
Length of output: 6738 @bdraco I've found your existing nitpick comments on the PR, and here are additional committable inline suggestions for other potential improvements: For the
For the
For the
For the
These suggestions remove the space after |
@coderabbitai I asked for commitable suggestions. They should use the github |
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@bdraco I understand now - here are the properly formatted GitHub committable suggestions: For the
For the
For the
For the
These suggestions remove the space after 🏁 Script executed:
Length of output: 5259 @bdraco Looking at the diff, I see exactly what needs fixing. Here are the properly formatted GitHub committable suggestions for each parameter: For the
For the
For the
For the
These suggestions remove the spaces after the |
Thanks. Will fix conflicts on the others after merging this |
Proposed change
Add docs for the required manual inputs for ESPHome
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
host
,port
,noise_psk
, andpassword
.