-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update http.markdown #38626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update http.markdown #38626
Conversation
Added information for clearing the ip ban and fixing some typos/grammar - make "server_port:" description more clear - login_attempts_threshold typo - Long-Lived Access Token plural removed
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User ->> Documentation: Reads about http integration
Documentation -->> User: Provides refined descriptions for options
User ->> Documentation: Looks up authentication token creation
Documentation -->> User: Supplies corrected instructions
User ->> Documentation: Seeks info on clearing IP bans
Documentation -->> User: Gives step-by-step guidance for removing bans and restarting
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/http.markdown (3)
77-78
: Add missing comma for readability.
In the sentence “When set to -1 no new automatic bans…”, add a comma after “-1” to improve clarity:- When set to -1 no new automatic bans will be added. + When set to -1, no new automatic bans will be added.🧰 Tools
🪛 LanguageTool
[uncategorized] ~78-~78: Possible missing comma found.
Context: ... of failed login attempts from a single IP after which it will be automatically ba...(AI_HYDRA_LEO_MISSING_COMMA)
132-132
: Use underscores for bold styling to comply with markdownlint.
Replace**Security**
and**User profile**
with_Security_
and_User profile_
(or use double underscores) to adhere to the project’s style rules. For example:- ...UI in the **Security** section of your {% my profile title="**User profile**" %} page. + ...UI in the _Security_ section of your {% my profile title="_User profile_" %} page.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
132-132: Strong style
Expected: underscore; Actual: asterisk(MD050, strong-style)
132-132: Strong style
Expected: underscore; Actual: asterisk(MD050, strong-style)
132-132: Strong style
Expected: underscore; Actual: asterisk(MD050, strong-style)
132-132: Strong style
Expected: underscore; Actual: asterisk(MD050, strong-style)
145-146
: Improve grammar by adding a comma.
Add a comma after the introductory clause for correct punctuation:- After a ban is added a Persistent Notification will appear... + After a ban is added, a Persistent Notification will appear...🧰 Tools
🪛 LanguageTool
[uncategorized] ~145-~145: A comma might be missing here.
Context: ...016-11-16T19:20:03" ``` After a ban is added a Persistent Notification will appear i...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/http.markdown
(4 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/http.markdown
[uncategorized] ~78-~78: Possible missing comma found.
Context: ... of failed login attempts from a single IP after which it will be automatically ba...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~145-~145: A comma might be missing here.
Context: ...016-11-16T19:20:03" ``` After a ban is added a Persistent Notification will appear i...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/http.markdown
132-132: Strong style
Expected: underscore; Actual: asterisk
(MD050, strong-style)
132-132: Strong style
Expected: underscore; Actual: asterisk
(MD050, strong-style)
132-132: Strong style
Expected: underscore; Actual: asterisk
(MD050, strong-style)
132-132: Strong style
Expected: underscore; Actual: asterisk
(MD050, strong-style)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/http.markdown (2)
37-38
: Approve server_port description update.
The new wording clearly and accurately describes the purpose ofserver_port
.
147-152
: Approve IP ban clearance instructions.
The new steps clearly explain how to remove individual bans or reset the entire ban list, and the restart reminder ensures changes are applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cogneato 👍
../Frenck
Added information for clearing the ip ban and fixing some typos/grammar
Proposed change
Add information on clearing the IP ban as this is commonly sought in the community forum and elsewhere.
Fixed some minor typos and added clarity elsewhere
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit