-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add 3 stars to description #38639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 stars to description #38639
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughA new time sensor, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant JewishCalendarIntegration
User->>JewishCalendarIntegration: Request list of available time sensors
JewishCalendarIntegration-->>User: Return sensors including t_set_hakochavim_3_stars
Assessment against linked issues
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/jewish_calendar.markdown (1)
73-75
: Add Hebrew transliteration and translation for the new sensor for consistency.
Most existing time sensors include both the romanized name and the Hebrew term in parentheses (e.g.,(Tseit Hakochavim – צאת הכוכבים)
). Consider updating the new entry to:- - `t_set_hakochavim_3_stars`: Time at which 3 stars are visible, mostly used for Havdalah + - `t_set_hakochavim_3_stars`: Time at which three stars are visible (Tseit HaKochavim Meshalosh – צאת הכוכבים שלוש), mostly used for HavdalahThis will keep the style consistent across the sensor list.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/jewish_calendar.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tsvi 👍
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit