Skip to content

Add remaining Binary Sensor entities to Teslemetry #38648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

Add remaining Binary Sensor entities to Teslemetry #38648

merged 2 commits into from
Apr 22, 2025

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Apr 21, 2025 •
edited by coderabbitai bot
Loading

Proposed change

Add remaining Binary Sensor entities to Teslemetry

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated Teslemetry integration documentation to include additional binary sensor entities: Charge enable request, Defrost for preconditioning, High beams, HVAC auto mode, High voltage interlock loop fault, Remote start, Seat vent enabled, and Speed limited. These sensors are not enabled by default.

@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Apr 21, 2025
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@netlify Netlify
Copy link

netlify bot commented Apr 21, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 849298d
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6805f468e0146e0008e29703
😎 Deploy Preview https://deploy-preview-38648--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Bre77 Bre77 mentioned this pull request Apr 21, 2025
Merged
19 tasks
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 21, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 21, 2025 •
edited
Loading

📝 Walkthrough

"""

Walkthrough

The documentation for the Teslemetry integration was updated to include additional binary sensor entities under the Vehicles section. The newly added sensors are "Charge enable request," "Defrost for preconditioning," "High beams," "HVAC auto mode," "High voltage interlock loop fault," "Remote start," "Seat vent enabled," and "Speed limited." All these sensors are marked as not enabled by default. There were no changes to the codebase, functionality, error handling, or declarations of exported or public entities; the update is strictly documentation.

Changes

File(s) Change Summary
source/_integrations/teslemetry.markdown Updated documentation to add multiple new binary sensor entities under the Vehicles section.

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to documentation updates.
"""

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 019aef5 and 849298d.

📒 Files selected for processing (1)
  • source/_integrations/teslemetry.markdown (3 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/teslemetry.markdown

[duplication] ~71-~71: Possible typo: you repeated a word.
Context: ...inary sensor|Dashcam|No| |Binary sensor|DC DC|No| |Binary sensor|Defrost for precondi...

(ENGLISH_WORD_REPEAT_RULE)

[uncategorized] ~103-~103: Did you mean the adjective “Right-hand”?
Context: ... sensor|Remote start|No| |Binary sensor|Right hand drive|No| |Binary sensor|Scheduled char...

(MISSING_HYPHEN)

🔇 Additional comments (8)
source/_integrations/teslemetry.markdown (8)

67-67: Approve addition of "Charge enable request"
The new binary sensor entry for “Charge enable request” is correctly formatted under the Vehicles table, and the default enabled status “No” matches the existing convention.

72-72: Approve addition of "Defrost for preconditioning"
The “Defrost for preconditioning” binary sensor is properly added and follows the same table structure and default value as other entries.

85-85: Approve addition of "High beams"
The “High beams” binary sensor row is correctly inserted and uses the expected “No” default flag.

87-87: Approve addition of "HVAC auto mode"
The table entry for “HVAC auto mode” is consistent with the other binary sensors and adheres to documentation style.

88-88: Approve addition of "High voltage interlock loop fault"
The long sensor name “High voltage interlock loop fault” is correctly placed, and the “No” default value is consistent with similar entries.

102-102: Approve addition of "Remote start"
The “Remote start” binary sensor has been added in the right alphabetical position with the correct default status.

105-105: Approve addition of "Seat vent enabled"
The “Seat vent enabled” entry follows naming conventions and table formatting guidelines.

107-107: Approve addition of "Speed limited"
The “Speed limited” binary sensor listing is accurate and consistent with the overall Vehicles section.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

c0ffeeca7
c0ffeeca7 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Bre77 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Apr 22, 2025
@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Apr 22, 2025
@frenck frenck merged commit 20c24bb into home-assistant:next Apr 22, 2025
6 of 7 checks passed
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already in-progress This PR/Issue is currently being worked on labels Apr 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bre77 @c0ffeeca7 @frenck