Skip to content

Rename Nuki to Nuki Bridge #38676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Rename Nuki to Nuki Bridge #38676

merged 2 commits into from
Apr 23, 2025

Conversation

edenhaus
Copy link
Member

@edenhaus edenhaus commented Apr 22, 2025

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the integration documentation to clarify that it specifically covers controlling Nuki Smart Locks via the Nuki Bridge, with a simplified introduction.

@edenhaus edenhaus requested review from pvizeli and pree as code owners April 22, 2025 15:32
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 22, 2025
Copy link

netlify bot commented Apr 22, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit c1c18b0
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6808e3b65e3e4500081317fe
😎 Deploy Preview https://deploy-preview-38676--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 22, 2025

📝 Walkthrough

Walkthrough

The documentation for the Nuki integration was revised to focus specifically on the "Nuki Bridge" rather than the broader category of Nuki smart lock devices. The introductory section was updated to remove references to WiFi-enabled Nuki smart locks and cloud-based control, now specifying control exclusively via the Nuki Bridge. No changes were made to the technical details or other sections of the document.

Changes

File(s) Change Summary
source/_integrations/nuki.markdown Updated title and introduction to emphasize "Nuki Bridge" and removed cloud/WiFi references.

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to documentation updates.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
source/_integrations/nuki.markdown (1)

22-22: Clarify integration name and remove trailing spaces
The introduction still reads “The Nuki integration…” but the integration has been renamed. Change this to “The Nuki Bridge integration…” and remove the trailing space at the end of the line to satisfy markdownlint.

Proposed diff:

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20c24bb and 8034279.

📒 Files selected for processing (1)
  • source/_integrations/nuki.markdown (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/nuki.markdown

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Copy link
Contributor

coderabbitai bot commented Apr 22, 2025

📝 Walkthrough

Walkthrough

The documentation for the Nuki integration was updated to clarify that it specifically pertains to controlling Nuki Smart Locks via the Nuki Bridge. References to controlling locks with built-in WiFi through the cloud were removed, and the title and introductory sentence were revised for greater specificity. No changes were made to the technical content, configuration, or functionality described in the document.

Changes

File(s) Change Summary
source/_integrations/nuki.markdown Updated title and introduction to specify focus on the Nuki Bridge; removed references to WiFi/cloud integration.

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to documentation wording and do not affect control flow or feature implementation.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
source/_integrations/nuki.markdown (1)

1-91: 💡 Verification agent

🧩 Analysis chain

Verify no remaining “Nuki integration” references
To ensure all internal links and mentions across the docs have been updated to “Nuki Bridge,” run:

This will help catch any missed occurrences in the markdown.


🏁 Script executed:

#!/bin/bash
# Verify no lingering references to "Nuki integration"
rg -n "Nuki integration" source/_integrations

Length of output: 262


Replace remaining “Nuki integration” reference with “Nuki Bridge”
There’s still one occurrence that needs updating:

• File source/_integrations/nuki.markdown, line 22

- The Nuki integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge](https://help.nuki.io/hc/en-001/sections/360004474718-Bridge). 
+ The Nuki Bridge allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge](https://help.nuki.io/hc/en-001/sections/360004474718-Bridge). 
🧰 Tools
🪛 LanguageTool

[uncategorized] ~27-~27: The preposition “on” seems more likely in this position than the preposition “in”.
Context: ...n on the HTTP API and check the details in the screen. Please note that the API to...

(AI_EN_LECTOR_REPLACEMENT_PREPOSITION_IN_ON)


[typographical] ~27-~27: If specifying a range, consider using an en dash instead of a hyphen.
Context: ...lease note that the API token should be 6-20 characters long, even though the app al...

(HYPHEN_TO_EN)


[style] ~40-~40: In American English, abbreviations like “etc.” require a period.
Context: ...ce issues with the API (authentication, etc). The default is True. {% endconfigur...

(ETC_PERIOD)

🪛 markdownlint-cli2 (0.17.2)

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


23-23: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


52-52: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe

(MD055, table-pipe-style)


53-53: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe

(MD055, table-pipe-style)


61-61: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe

(MD055, table-pipe-style)


62-62: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe

(MD055, table-pipe-style)


72-72: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe

(MD055, table-pipe-style)


73-73: Table pipe style
Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe

(MD055, table-pipe-style)


77-77: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)


88-88: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

🧹 Nitpick comments (3)
source/_integrations/nuki.markdown (3)

2-2: Title capitalization consistency
The title uses “Nuki bridge” with a lowercase “b.” For consistency with branding and other integration titles, capitalize “Bridge”: use

- title: Nuki bridge
+ title: Nuki Bridge

3-3: Refine description for clarity and consistency
The description line still refers to “a Nuki bridge” and uses “their.” Consider updating to use “Nuki Bridge” (capital B) and “your” to improve readability:

- description: Instructions on how to integrate a Nuki bridge to control their Smart Lock devices.
+ description: Instructions on how to integrate a Nuki Bridge to control your Smart Lock devices.

22-22: Update introductory sentence and remove trailing whitespace
The sentence still reads “The Nuki integration” and has trailing spaces at the end. Align with the PR objectives and remove extra spaces:

- The Nuki integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge](https://help.nuki.io/hc/en-001/sections/360004474718-Bridge).  
+ The Nuki Bridge integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge](https://help.nuki.io/hc/en-001/sections/360004474718-Bridge).
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20c24bb and 8034279.

📒 Files selected for processing (1)
  • source/_integrations/nuki.markdown (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/nuki.markdown

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

@pree
Copy link
Member

pree commented Apr 22, 2025

Whats the motivation for this change? I think we could add an option for different connection modes inside one integration. I dont know what is preferred.

@frenck
Copy link
Member

frenck commented Apr 22, 2025

Whats the motivation for this change? I think we could add an option for different connection modes inside one integration. I dont know what is preferred.

Nuki has multiple integrations and will be added as a brand too with their Matter products. Meaning this will become problematic for a user to pick the right integration if this one is just called "Nuki".

I think we could add an option for different connection modes inside one integration

That won't work for IoT standards like Matter.

@pree
Copy link
Member

pree commented Apr 22, 2025

Thanks for the clarification @frenck

c0ffeeca7
c0ffeeca7 previously approved these changes Apr 23, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @edenhaus 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Apr 23, 2025
@edenhaus edenhaus changed the title Rename Nuki to Nuki bridge Rename Nuki to Nuki Bridge Apr 23, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
source/_integrations/nuki.markdown (1)

2-3: Frontmatter naming updated correctly
The title and description fields now consistently use “Nuki Bridge”, aligning with Home Assistant naming conventions. One optional grammar nitpick: consider replacing “their” with “its” to refer to the Bridge singularly in the description.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8034279 and c1c18b0.

📒 Files selected for processing (1)
  • source/_integrations/nuki.markdown (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/nuki.markdown

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

@@ -19,7 +19,7 @@ ha_dhcp: true
ha_integration_type: integration
---

The Nuki integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge](https://help.nuki.io/hc/en-001/sections/360004474718-Bridge) or Nuki Smart Lock with [Build-in WiFi](https://help.nuki.io/hc/en-001/sections/4402761196817-Built-in-Wi-Fi) using the cloud.
The Nuki integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge](https://help.nuki.io/hc/en-001/sections/360004474718-Bridge).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Clarify integration name and remove trailing whitespace
Update the sentence to reference “Nuki Bridge integration” for clarity and trim the trailing space at the end.

-The Nuki integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge]. 
+The Nuki Bridge integration allows you to control [Nuki Smart Locks](https://nuki.io/en/smart-lock/) via a [Nuki Bridge].

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

22-22: Trailing spaces
Expected: 0 or 2; Actual: 1

(MD009, no-trailing-spaces)

@home-assistant home-assistant bot added the parent-merged The parent PR has been merged already label Apr 23, 2025
@c0ffeeca7 c0ffeeca7 merged commit 4ff5c8b into next Apr 23, 2025
9 checks passed
@c0ffeeca7 c0ffeeca7 deleted the edenhaus-nuki-rename branch April 23, 2025 13:16
@home-assistant home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Apr 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants