-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add data-updates documention to Renault #38678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughA new section was added to the Renault integration documentation to specify that the integration enforces a polling limit of 60 data requests per hour due to Renault server rate restrictions. It clarifies that for a single vehicle with all seven data endpoints enabled, data is fetched approximately every 7 minutes. Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to documentation updates. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/renault.markdown (3)
56-56
: Improve grammar and formatting in rate limit description.Use plural "rate limits" and avoid the slash; prefer "per hour" for clarity:
- Due to rate limitation from the Renault servers, the integration limits polling to 60 data requests / hour. + Due to rate limits from the Renault servers, the integration limits polling to 60 data requests per hour.
57-57
: Spell out single-digit numbers for consistency.Consider writing "all seven endpoints" instead of "all 7 endpoints" to align with Home Assistant documentation style:
- For a single vehicle with all 7 endpoints available, the integration fetches data from the device every 7 minutes. + For a single vehicle with all seven endpoints available, the integration fetches data from the device every 7 minutes.
54-58
: Use an informational admonition for data updates.To visually distinguish rate-limit guidance and improve readability, wrap this section in an admonition block:
!!! note "Data updates" Due to rate limits from the Renault servers, the integration limits polling to 60 data requests per hour. For a single vehicle with all seven endpoints available, the integration fetches data every 7 minutes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/renault.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/renault.markdown (1)
54-54
: Section placement and heading formatting is correct.The new "Data updates" section uses the appropriate heading level and is placed logically before the "Actions" section, matching the structure of other integration docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @epenet 👍
Proposed change
Relates to home-assistant/core#142964
cc @tmenguy
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit