Update ubus.markdown #38683
Merged
Update ubus.markdown #38683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Ubus integration has been updated to clarify the handling of the ACL file during OpenWrt firmware upgrades. The previous guidance, which suggested that the ACL file must be recreated after every update, has been replaced. The new instructions advise users to add the ACL file path to Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant OpenWrt System
User->>OpenWrt System: Create ACL file
User->>OpenWrt System: Add ACL file path to /etc/sysupgrade.conf
Note right of OpenWrt System: Ensures ACL file persists after upgrade
User->>OpenWrt System: Restart rpcd and uhttpd services
OpenWrt System-->>User: Services restarted with ACL changes applied
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/ubus.markdown (1)
60-60: Clarify persistence instructions and provide command examples
The current line “Restart the services. Add the file to /etc/sysupgrade.conf …” bundles two steps and omits the exact file path and method to append it. Splitting into separate instructions and showing concrete commands will improve clarity.- Restart the services. Add the file to /etc/sysupgrade.conf so that it remains after updating/upgrading your OpenWrt firmware. + Restart the services: + + ```bash + /etc/init.d/rpcd restart && /etc/init.d/uhttpd restart + ``` + + To keep the ACL file (`/usr/share/rpcd/acl.d/hass.json`) across OpenWrt firmware upgrades, append it to `/etc/sysupgrade.conf`: + + ```bash + echo '/usr/share/rpcd/acl.d/hass.json' >> /etc/sysupgrade.conf + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/ubus.markdown(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
agners
previously approved these changes
Apr 28, 2025
Co-authored-by: Stefan Agner <stefan@agner.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add the hass.json file to /etc/sysupgrade.conf so that it remains after upgrade.
Type of change
currentbranch).Checklist
currentbranch.nextbranch.Summary by CodeRabbit
/etc/sysupgrade.confinstead of recreating it after each update.