-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update operating_system.md #38696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update operating_system.md #38696
Conversation
The correct network adapter options are E1000 and E1000E
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for operating system installation was updated to correct the recommended VMware ESXi/vSphere virtual network adapters. The previous recommendation of "E1001" or "E1001E" was changed to "E1000" or "E1000E" due to known mDNS/Multicast discovery issues with the "VMXnet3" adapter. No changes were made to any application logic, error handling, or control flow. Changes
Sequence Diagram(s)No sequence diagram is provided as the changes are limited to documentation updates and do not affect control flow or introduce new features. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_includes/installation/operating_system.md (1)
444-444
: Use inline code formatting for adapter names
It's clearer and more consistent with the rest of the documentation to render network adapter identifiers as inline code. Consider updating this line as follows:- Use the “E1000” or “E1000E” virtual network adapter. There are confirmed mDNS/Multicast discovery issues when using VMware’s “VMXnet3” virtual network adapter. + Use the `E1000` or `E1000E` virtual network adapter. There are confirmed mDNS/multicast discovery issues when using VMware's `VMXNET3` virtual network adapter.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_includes/installation/operating_system.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Based on @coderabbitai Nitpick comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @benwa 👍
../Frenck
The correct network adapter options are E1000 and E1000E
Proposed change
Update documentation
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit