Skip to content

Updated operating_system and add Proxmox cli information for haos #38746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

pdrberg
Copy link

@pdrberg pdrberg commented Apr 25, 2025

Proposed change

Add Proxmox CLI information

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • [ X] This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [X ] The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Added detailed instructions for setting up a virtual machine with Proxmox, including sample commands and guidance for USB dongle passthrough configuration.

Add KVM/Proxmox cli information
@home-assistant home-assistant bot added the current This PR goes into the current branch label Apr 25, 2025
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit d5dcc19
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/680b986bfdac3400087fc6cf
😎 Deploy Preview https://deploy-preview-38746--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 25, 2025

📝 Walkthrough

Walkthrough

A new section was added to the documentation under the "Hypervisor specific configuration" area, specifically for KVM/Proxmox environments. This addition introduces step-by-step instructions for creating a virtual machine using Proxmox, including a sample command and options for configuring memory, CPU, BIOS, and disk settings. The documentation also explains how to attach a USB dongle to the VM, providing guidance on identifying the dongle's bus and device IDs using the lsusb command and incorporating them into the Proxmox configuration.

Changes

File(s) Change Summary
source/_includes/installation/operating_system.md Added a new "KVM/Proxmox" tab with instructions for VM creation and USB dongle passthrough, including example commands and guidance on using lsusb.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation
    participant Proxmox
    participant USB Dongle

    User ->> Documentation: Reads KVM/Proxmox VM creation instructions
    User ->> Proxmox: Runs 'qm create' command with VM parameters
    User ->> USB Dongle: Runs 'lsusb' to identify dongle IDs
    User ->> Proxmox: Adds USB passthrough option with dongle's vendor/product ID
    Proxmox -->> USB Dongle: Attaches USB device to VM
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (2)
source/_includes/installation/operating_system.md (2)

404-405: Consistent title formatting for Proxmox section
To match the style of other hypervisor tabs (e.g., “KVM (virt-install)”), consider renaming the tab title from “KVM/Proxmox” to something like “Proxmox (qm create)”.


407-409: Standardize placeholders and clarify storage identifier

  • Use consistent placeholder casing: <PATH TO QCOW2 FILE> (all uppercase).
  • Add a note that <STORAGE> refers to the Proxmox storage ID (for example local-lvm, rbd, or a named storage).
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0097062 and d5dcc19.

📒 Files selected for processing (1)
  • source/_includes/installation/operating_system.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Comment on lines +411 to +424
{% icon "mdi:alert-outline" %} If you have a USB
dongle to attach, you need to add the option `--usb<ID> host=busID.deviceId`. You can
discover these IDs via the `lsusb` command. As example, if `lsusb` output is:

```bash
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 004: ID 1a86:55d4 QinHeng Electronics SONOFF Zigbee 3.0 USB Dongle Plus V2
Bus 001 Device 003: ID 05e3:0610 Genesys Logic, Inc. Hub
Bus 001 Device 002: ID 05e3:0608 Genesys Logic, Inc. Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Correct USB passthrough instructions and syntax
Proxmox expects vendor:product IDs for USB passthrough, not bus.device notation. Also remove the colon after the --usb0 flag. For example:

- {% icon "mdi:alert-outline" %} If you have a USB
- dongle to attach, you need to add the option `--usb<ID> host=busID.deviceId`. You can
- discover these IDs via the `lsusb` command. As example, if `lsusb` output is:
+ {% icon "mdi:alert-outline" %} If you have a USB dongle to attach, add `--usb0 host=vendorID:productID`.  
+ You can discover vendor:product IDs with:
+ ```bash
+ lsusb
+ ```  

Ensure the user replaces vendorID:productID with the IDs from the ID column in the lsusb output.

Comment on lines +431 to 433
Note that this configuration (bus 003, device 003) is just an example, your dongle could be on another bus and/or with another device ID.
Please check the correct IDs of your USB dongle with `lsusb`.
{% endunless %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update note to match Proxmox example
The note still refers to “bus 003, device 003” (from the KVM virt-install example), but for Proxmox we used “Bus 001 Device 004”. Update accordingly to avoid confusion.

- Note that this configuration (bus 003, device 003) is just an example, your dongle could be on another bus and/or with another device ID.
+ Note that this configuration (bus 001, device 004) is just an example, your dongle could be on another bus and/or with another device ID.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Note that this configuration (bus 003, device 003) is just an example, your dongle could be on another bus and/or with another device ID.
Please check the correct IDs of your USB dongle with `lsusb`.
{% endunless %}
Note that this configuration (bus 001, device 004) is just an example, your dongle could be on another bus and/or with another device ID.
Please check the correct IDs of your USB dongle with `lsusb`.
{% endunless %}

Comment on lines +426 to +430

```bash
qm create 9999 --name Home Assistent OS --memory 4096 --cores 2 --bios ovmf --machine q35 --ostype l26 --scsihw virtio-scsi-pci --scsi0 nvme:0,import-from=rbnas03-proxmox:import/haos_ova-11.4.qcow2 --boot order=scsi0 --efidisk0 nvme:0,format=raw,efitype=4m,pre-enrolled-keys=1 --serial0 socket --vga serial0 --usb0: host=1a86:55d4
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix VM name typo and flag syntax in example command

  • Correct “Home Assistent OS” to “Home Assistant OS”.
  • Wrap the VM name in quotes if it contains spaces.
  • Remove the colon after --usb0.
- qm create 9999 --name Home Assistent OS --memory 4096 --cores 2 --bios ovmf --machine q35  --ostype l26 --scsihw virtio-scsi-pci --scsi0 nvme:0,import-from=rbnas03-proxmox:import/haos_ova-11.4.qcow2 --boot order=scsi0 --efidisk0 nvme:0,format=raw,efitype=4m,pre-enrolled-keys=1 --serial0 socket --vga serial0 --usb0: host=1a86:55d4
+ qm create 9999 --name "Home Assistant OS" --memory 4096 --cores 2 --bios ovmf --machine q35 \
+   --ostype l26 --scsihw virtio-scsi-pci --scsi0 nvme:0,import-from=rbnas03-proxmox:import/haos_ova-11.4.qcow2 \
+   --boot order=scsi0 --efidisk0 nvme:0,format=raw,efitype=4m,pre-enrolled-keys=1 \
+   --serial0 socket --vga serial0 --usb0 host=1a86:55d4
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
```bash
qm create 9999 --name Home Assistent OS --memory 4096 --cores 2 --bios ovmf --machine q35 --ostype l26 --scsihw virtio-scsi-pci --scsi0 nvme:0,import-from=rbnas03-proxmox:import/haos_ova-11.4.qcow2 --boot order=scsi0 --efidisk0 nvme:0,format=raw,efitype=4m,pre-enrolled-keys=1 --serial0 socket --vga serial0 --usb0: host=1a86:55d4
```

@mib1185
Copy link
Contributor

mib1185 commented Apr 25, 2025

This was already tried with #37997, but postponed after the current hardware platform and installation method deprecations are agreed and rolled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants