Skip to content

chore: use of correct 24-hour clock terminology #38758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

chore: use of correct 24-hour clock terminology #38758

merged 2 commits into from
Apr 28, 2025

Conversation

alastairmccormack
Copy link
Contributor

@alastairmccormack alastairmccormack commented Apr 26, 2025 •
edited by coderabbitai bot
Loading

Proposed change

Replaced the use of "military" time for "24-hour" time, which is better understood internationally and is more accurate for times with a colon in them.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated documentation to clarify that time inputs should use the "24-hour time format" instead of "military time format" in relevant sections.

@home-assistant home-assistant bot added the current This PR goes into the current branch label Apr 26, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 26, 2025

📝 Walkthrough

Walkthrough

The changes update documentation in two markdown files to replace the phrase "military time format" with "24-hour time format" when describing time input formats. This affects explanatory text related to time triggers and the today_at(value) function, ensuring consistent and clear terminology. No code or configuration logic is modified, and there are no changes to public or exported entities.

Changes

File(s) Change Summary
source/_docs/automation/trigger.markdown Updated documentation to describe time format as "24-hour time format" instead of "military."
source/_docs/configuration/templating.markdown Changed description of today_at(value) input to use "24-hour time format" terminology.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78ceca8 and 49b4e34.

📒 Files selected for processing (2)
  • source/_docs/automation/trigger.markdown (1 hunks)
  • source/_docs/configuration/templating.markdown (1 hunks)
🔇 Additional comments (2)
source/_docs/automation/trigger.markdown (1)

699-701: Corrected terminology to "24-hour time format"
The phrase has been accurately updated from "military time format" to the clearer, internationally recognized "24-hour time format" when describing the at parameter.

source/_docs/configuration/templating.markdown (1)

730-731: Updated "today_at" description to use "24-hour time format"
The today_at(value) function docs now consistently reference "24-hour time format" instead of "military time format," matching terminology across the documentation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Apr 26, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 2c897da
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/680e1c64f229af0008725747
😎 Deploy Preview https://deploy-preview-38758--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

c0ffeeca7
c0ffeeca7 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alastairmccormack 👍

@c0ffeeca7 c0ffeeca7 merged commit 563bfd3 into home-assistant:current Apr 28, 2025
7 checks passed
@alastairmccormack alastairmccormack deleted the doc-24hour-time branch April 28, 2025 08:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alastairmccormack @c0ffeeca7