Skip to content

Add documentation on Miele vacuum platform #38770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

astrandb
Copy link
Contributor

@astrandb astrandb commented Apr 27, 2025

Proposed change

Add description of vacuum entity

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated Miele integration documentation to include support for vacuum devices.
    • Added details on monitoring and controlling Miele robot vacuum cleaners, including supported features such as start, stop, pause, and fan speed adjustment.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 27, 2025
Copy link

netlify bot commented Apr 27, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit ffc3533
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/68186bd762d18700086471f7
😎 Deploy Preview https://deploy-preview-38770--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Apr 27, 2025

📝 Walkthrough

Walkthrough

The documentation for the Miele integration was updated to reflect new support for vacuum devices. The metadata in the documentation now lists "Vacuum" as a supported category and platform. A new section describing vacuum entity support, including available controls and monitoring capabilities, was added. The structure of the documentation was adjusted to properly close and open details blocks for entity types. No changes were made to existing entity types or automation examples.

Changes

File(s) Change Summary
source/_integrations/miele.markdown Added "Vacuum" to integration metadata, introduced a new section for vacuum entity support, adjusted details block structure for entity descriptions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Miele Integration Documentation

    User->>Miele Integration Documentation: Access documentation
    Miele Integration Documentation-->>User: Display supported categories (now includes Vacuum)
    User->>Miele Integration Documentation: View Vacuum entity section
    Miele Integration Documentation-->>User: Show controls and monitoring info for Vacuum devices
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 68f3d2d and ffc3533.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/_integrations/miele.markdown
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/miele.markdown (1)

155-160: Document the Vacuum entity
The new ### Vacuum section and nested {% details %} block accurately describe Miele robot vacuums (start, stop, pause, fan speed). Consider enriching this section with additional attributes (e.g., battery level, status) if supported by the API:

 ### Vacuum
 
 {% details "List of vacuum entities" %}
 
 - **Robot vacuum cleaner**: Miele robot vacuum cleaners can be monitored and controlled to a limited extent. The device can be started, stopped, and paused. The fan speed can also be set.
+ - **Battery level**: Reports the current battery percentage of the device.
 {% enddetails %}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f902f68 and 68f3d2d.

📒 Files selected for processing (1)
  • source/_integrations/miele.markdown (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/miele.markdown (3)

12-12: Add Vacuum to supported categories
The new - Vacuum entry under ha_category aligns with the existing Title-case style. This correctly advertises the vacuum entity in the integration metadata.


27-27: Include vacuum in ha_platforms
Adding - vacuum to the ha_platforms list follows Home Assistant conventions (all lowercase, underscore-free). Ensure that the vacuum platform is exercised in CI tests to avoid any missing template or translation errors.


122-123: Properly close the Light details block
The explicit {% enddetails %} on line 122 (and subsequent blank line) prevents the Light section from bleeding into the Binary sensor section, restoring correct Markdown structure.

c0ffeeca7
c0ffeeca7 previously approved these changes Apr 28, 2025
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @astrandb 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants