-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Adding the possible values of the prices descriptors to the documenta38714 #38773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the possible values of the prices descriptors to the documenta38714 #38773
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Amber Electric integration was updated to enhance the explanation of the "Descriptor" sensor. The update specifically enumerates all possible values that the Descriptor sensor can take: Changes
Assessment against linked issues
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/amberelectric.markdown (1)
48-48
: Fix the indefinite article before “Amber light”.Change “a Amber light” to “an Amber light” for correct English usage.
- **Descriptor** - A description of the price. Useful if you want to create a Amber light that matches the app. Possible values: `extremely_low`, `very_low`, `low`, `neutral`, `high`, and `spike`. + **Descriptor** - A description of the price. Useful if you want to create an Amber light that matches the app. Possible values: `extremely_low`, `very_low`, `low`, `neutral`, `high`, and `spike`.🧰 Tools
🪛 LanguageTool
[misspelling] ~48-~48: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...the price. Useful if you want to create a Amber light that matches the app. Possi...(EN_A_VS_AN)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/amberelectric.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/amberelectric.markdown
[misspelling] ~48-~48: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...the price. Useful if you want to create a Amber light that matches the app. Possi...
(EN_A_VS_AN)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @madpilot 👍
Proposed change
Minor change to include the possible values of the price descriptor sensor, making it easier for users to write their own automations against it.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.Summary by CodeRabbit