-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add polling interval section to Tesla Fleet #38789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Tesla Fleet integration was updated to include a new collapsible section detailing the vehicle data polling interval, explaining its default behavior and providing guidance for customization. Additionally, minor formatting improvements were made in the section about registering as a Fleet API partner, specifically cleaning up whitespace around code blocks and list items. No functional instructions, commands, or public entities were changed. Changes
Sequence Diagram(s)Not applicable; the changes are limited to documentation and formatting updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/tesla_fleet.markdown (1)
53-54
: Remove redundant blank line.
There are two consecutive blank lines at lines 53–54 before the new section. Please collapse these into a single blank line to resolve MD012 (no multiple consecutive blank lines).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
54-54: Multiple consecutive blank lines
Expected: 1; Actual: 2(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/tesla_fleet.markdown
(4 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/tesla_fleet.markdown
54-54: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/tesla_fleet.markdown (1)
57-65
: Approve addition of “Vehicle data polling interval” section.
The collapsible details block concisely explains the default 10 minute polling interval, ties it to Tesla’s free usage credit, and links users to customization instructions. The style and formatting align with existing integration docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/tesla_fleet.markdown (1)
163-163
: Typo: use "it's" instead of "its"
Replace "its awake" with "it's awake" to correct the contraction.🧰 Tools
🪛 LanguageTool
[uncategorized] ~163-~163: “its” (belonging to it) seems less likely than “it’s” (it is)
Context: ...oll each vehicle every 10 minutes while its awake. This is long enough that a singl...(AI_HYDRA_LEO_CPT_ITS_ITIS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/tesla_fleet.markdown
(5 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/tesla_fleet.markdown
[uncategorized] ~163-~163: “its” (belonging to it) seems less likely than “it’s” (it is)
Context: ...oll each vehicle every 10 minutes while its awake. This is long enough that a singl...
(AI_HYDRA_LEO_CPT_ITS_ITIS)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/tesla_fleet.markdown (3)
53-53
: Whitespace cleanup: trailing blank line removed
Improves the formatting of the prerequisites list by removing an unnecessary blank line.
105-105
: Whitespace cleanup around code block
The removal of extra blank lines before and after the shell snippet under "Register your application as a Fleet API partner" enhances readability.Also applies to: 119-119
161-168
: Add Vehicle data polling interval section
This new section clearly explains the default 10-minute polling interval, its fit within Tesla’s $10 usage credit, and provides a link for customizing the interval.🧰 Tools
🪛 LanguageTool
[uncategorized] ~163-~163: “its” (belonging to it) seems less likely than “it’s” (it is)
Context: ...oll each vehicle every 10 minutes while its awake. This is long enough that a singl...(AI_HYDRA_LEO_CPT_ITS_ITIS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! Thank you, @Bre77 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/tesla_fleet.markdown (1)
161-168
: Optional: Collapse this section for readability.
To keep long reference pages concise and consistent with other detailed sections (e.g., prerequisites), consider wrapping these lines in a{% details "Vehicle data polling interval" %}
block so users can expand it on demand.🧰 Tools
🪛 LanguageTool
[grammar] ~163-~163: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...he integration is configured to {% term polling poll %} each vehicle every 10 minutes while ...(REPEATED_VERBS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/tesla_fleet.markdown
(5 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/tesla_fleet.markdown
[grammar] ~163-~163: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...he integration is configured to {% term polling poll %} each vehicle every 10 minutes while ...
(REPEATED_VERBS)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/tesla_fleet.markdown (2)
163-163
: Ignore false-positive grammar warning.
The{% term polling poll %}
macro correctly renders a single “poll” invocation, so the repeated-verb flag from LanguageTool can be safely ignored.🧰 Tools
🪛 LanguageTool
[grammar] ~163-~163: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...he integration is configured to {% term polling poll %} each vehicle every 10 minutes while ...(REPEATED_VERBS)
161-168
: Great addition of polling interval details.
This new "Vehicle data polling interval" section clearly explains the default 10-minute polling behavior, cost implications, and provides a path for customization—addressing the missing information identified by the community.🧰 Tools
🪛 LanguageTool
[grammar] ~163-~163: You’ve repeated a verb. Did you mean to only write one of them?
Context: ...he integration is configured to {% term polling poll %} each vehicle every 10 minutes while ...(REPEATED_VERBS)
Proposed change
As suggested on discord, added a section on vehicle data polling.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit