-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add supported devices section for APCUPSD #38791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughA new "Supported devices" section was added to the documentation for the APC UPS Daemon integration. This section clarifies that the integration supports any device compatible with apcupsd, specifically mentioning most APC UPS models such as Smart-UPS and Back-UPS. No functional or configuration changes were made to the integration itself; the update is limited to providing additional informational content in the documentation. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are purely documentation updates without any control flow or feature modifications. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/apcupsd.markdown (1)
25-26
: Consider adding a comma for better readability
The sentence starts with 'Generally any device…'; adding a comma after 'Generally' improves clarity:
- Change "Generally any device supported by..."
- To "Generally, any device supported by..."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/apcupsd.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/apcupsd.markdown
[typographical] ~24-~24: Consider adding a comma after ‘Generally’ for more clarity.
Context: ... the APC device. ## Supported devices Generally any device supported by [apcupsd](http:...
(RB_LY_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/apcupsd.markdown (1)
23-23
: New 'Supported devices' section aligns with quality guidelines
This addition clearly informs users about the range of devices supported by the integration and follows the section conventions used in other Home Assistant docs. Great addition!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @yuxincs 👍
Proposed change
This PR follows https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/docs-supported-devices and lists down the supported devices. We support any device that is also supported by apcupsd. However, it seems that there is not a list of all supported models. In generally, the Smart-UPS and Back-UPS models should be supported according to https://wiki.debian.org/apcupsd.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit