-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update lamarzocco documentation #38810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the La Marzocco integration was revised to clarify how updates are received and processed. The updated text now specifically describes that the integration receives push updates from the cloud for general status, while other information is polled from the machine at set intervals. References to an optional local connection and immediate push updates were removed. Additionally, a troubleshooting section regarding real-time updates was deleted. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Integration
participant Cloud
participant Machine
Note over Integration: Regular operation
Cloud-->>Integration: Push updates (general status)
loop Every 30 seconds
Integration->>Machine: Poll for updates
end
loop Every 15 minutes
Integration->>Machine: Poll for statistics
end
loop Every hour
Integration->>Machine: Poll for firmware updates
end
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/lamarzocco.markdown (1)
38-38
: Polish update mechanism description for clarity and consistency
The current sentence is a bit long and uses “query” which isn’t standard in HA docs (we typically say “poll”). Consider rephrasing and, if you like, splitting into a short intro plus a bulleted list to improve readability.Example diff:
- By default, this integration will receive push updates from the cloud about its general status and otherwise query your machine every 30 seconds for an update, every 15 minutes for new statistics, and every hour for a firmware update. + By default, this integration receives push updates from the cloud for general status, and polls the machine at defined intervals: + - Every 30 seconds for status updates + - Every 15 minutes for statistics + - Every hour for firmware updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @zweckj 👍
@@ -35,7 +35,7 @@ This integration interacts with [La Marzocco](https://lamarzocco.com/it/en/) cof | |||
|
|||
If your Home Assistant host can perform [DHCP discovery](https://www.home-assistant.io/integrations/dhcp/), your machine will be discovered automatically. Otherwise, if your machine is in Bluetooth range to your Home Assistant host and the [Bluetooth](/integrations/bluetooth) integration is fully loaded, the machine will be discovered as well. | |||
|
|||
By default, this integration will receive push updates from the cloud and otherwise query your machine every 30 seconds for an update, every 15 minutes for new statistics, and every hour for a firmware update. If configure the optional local connection, your machine will receive immediate push updates about its state for everything except statistics and firmware updates. | |||
By default, this integration will receive push updates from the cloud about its general status and otherwise query your machine every 30 seconds for an update, every 15 minutes for new statistics, and every hour for a firmware update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, this integration will receive push updates from the cloud about its general status and otherwise query your machine every 30 seconds for an update, every 15 minutes for new statistics, and every hour for a firmware update. | |
By default, this integration will receive push updates from the cloud about its general status. In addition, the integration queries your machine every 30 seconds for an update, every 15 minutes for new statistics, and every hour for a firmware update. |
Tiny rephrase. Please correct me if I misunderstood this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not quite, it'll only query if the poll doesn't succeed hence the "otherwise"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I see. all good then. Thank you for clarifying.
Proposed change
removing some bits that have been missed in the first migration PR
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit