-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add Nuki Matter #38815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nuki Matter #38815
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughA new documentation file for the "Nuki Matter" integration has been added. This file introduces and describes the integration of Nuki Matter devices with Home Assistant via the Matter protocol. It outlines the integration's features, configuration methods, supported device types, and relevant links. The documentation notes that the integration is scheduled for release in version 2025.5 and is maintained by the Matter team. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant NukiMatterDevice
User->>HomeAssistant: Initiate Nuki Matter integration setup
HomeAssistant->>NukiMatterDevice: Discover and connect via Matter protocol
NukiMatterDevice-->>HomeAssistant: Provide device status and control capabilities
User->>HomeAssistant: Control or monitor Nuki Matter device
HomeAssistant->>NukiMatterDevice: Send commands (e.g., lock/unlock)
NukiMatterDevice-->>HomeAssistant: Respond with updated status
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
source/_integrations/nuki_matter.markdown (5)
4-14
: Normalize the IoT class value.In existing Home Assistant documentation,
ha_iot_class
uses lowercase with an underscore (e.g.,local_push
) rather than a title-cased string. Please update:-ha_iot_class: Local Push +ha_iot_class: local_push
2-3
: Clarify the description for consistency.The description is clear but could read more idiomatically:
-description: Control your Nuki Matter devices using the Matter integration. +description: Control Nuki Matter devices via the Matter integration.This removes redundant phrasing and aligns with other integration docs.
21-23
: Improve grammar and tone in introductory text.
- Line 21: Change “making sure” to “ensuring” for a more formal tone.
- Line 23: Replace “As all connectivity is happening locally” with “Because all connectivity happens locally” for readability.
-[Nuki](https://nuki.io) is committed to making sure their products are up-to-date and ready to use in Home Assistant. +[Nuki](https://nuki.io) is committed to ensuring their products remain up-to-date and compatible with Home Assistant. -Nuki Matter devices work locally and integrate seamlessly with the Matter integration in Home Assistant. As all connectivity is happening locally, status updates and controlling your devices happen instantly in Home Assistant. +Nuki Matter devices work locally and integrate seamlessly with the Matter integration in Home Assistant. Because all connectivity happens locally, status updates and control occur instantly within Home Assistant.
27-28
: Add a final newline and punctuation.
- Ensure there's a blank line at EOF.
- Add a period at the end of the link line for consistency with prose:
-[Learn more about Matter in Home Assistant.](/integrations/matter/) +[Learn more about Matter in Home Assistant.](/integrations/matter/).
20-28
: Enhance documentation structure with sections.The file currently has only a brief description. To align with other integration docs, consider adding headings such as:
Features
- Local Matter connectivity
- Instant status updates
Configuration
Navigate to Settings → Devices & Services, click Add Integration, and select Nuki Matter.
Resources
This improves readability and helps users find information quickly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/nuki_matter.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/nuki_matter.markdown (1)
25-25
: Verify the badge macro syntax.Most integration docs use the
add_integration_badge
macro, e.g.:{% my add_integration_badge(domain=page.ha_domain) %}Please confirm that
add_matter_device
is the correct macro name and syntax. If not, switch to the standard badge:{% my add_integration_badge(domain=page.ha_domain) %}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @edenhaus 👍
../Frenck
Nuki Matter devices work locally and integrate seamlessly with the Matter integration in Home Assistant. As all connectivity is happening locally, status updates and controlling your devices happen instantly in Home Assistant. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to list the devices?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @edenhaus 👍
Proposed change
Add Nuki Matter integration
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit