Skip to content

Update template cover, switch, and light documentation. #38822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Petro31
Copy link
Contributor

@Petro31 Petro31 commented Apr 30, 2025

Proposed change

Update template documentation for PRs

I added all these changes in a single PR because it would be a merge nightmare if they were separate.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the template integration documentation to include switch and cover entity types in relevant sections.
    • Clarified and expanded the list of supported entity types in the YAML configuration examples and section headings.

@Petro31 Petro31 requested a review from a team as a code owner April 30, 2025 11:52
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 30, 2025
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 1c344c0
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/68120f074d54600008f15107
😎 Deploy Preview https://deploy-preview-38822--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Petro31 Petro31 changed the title Update-switch-light-cover-document-changes Update template cover, switch, and light documentation. Apr 30, 2025
Copy link
Contributor

coderabbitai bot commented Apr 30, 2025

📝 Walkthrough

Walkthrough

The documentation for the template integration was updated to reflect support for additional entity types, specifically switch and cover. These types are now included in various sections, such as introductory descriptions, YAML configuration examples, and headings for state-based and trigger-based template entities. The documentation also reorganizes the mention of the cover integration, moving it from the main list to the legacy list in the legacy types section. No changes were made to code or public API declarations; only the documentation content was updated.

Changes

File(s) Change Summary
source/_integrations/template.markdown Updated documentation to include switch and cover entity types in multiple sections, expanded YAML configuration examples, and reorganized legacy types listing.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation
    User ->> Documentation: Reads about template integration
    Documentation -->> User: Presents updated entity types (including switch, cover)
    User ->> Documentation: Checks YAML configuration section
    Documentation -->> User: Shows configuration options for all supported entities
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (4)
source/_integrations/template.markdown (4)

60-63: Ensure lists are surrounded by blank lines
Per Markdown lint (MD032), lists should be preceded and followed by an empty line to improve readability and avoid rendering issues. Please add a blank line before the - [Cover]… entry and one after the list.

  For Legacy types, please see the specific pages:
+ 
  - [Cover](/integrations/cover.template/)
  - [Light](/integrations/light.template/)
  - [Switch](/integrations/switch.template/)
+ 
 {% include integrations/config_flow.md %}
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

60-60: Lists should be surrounded by blank lines
null

(MD032, blanks-around-lists)


78-78: Grammar: use “weather entities” instead of “weathers”
The plural “weathers” is unconventional. For consistency with other sections, replace it with “weather entities.”

- Entities (binary sensors, buttons, covers, images, lights, numbers, selects, sensors, switches, and weathers) are defined in your YAML configuration files under the `template:` key.
+ Entities (binary sensors, buttons, covers, images, lights, numbers, selects, sensors, switches, and weather entities) are defined in your YAML configuration files under the `template:` key.

82-82: Grammar: replace “weathers” with “weather entities” in heading
Align terminology with the rest of the document by using “weather entities” in the section title.

- ### State-based template binary sensors, buttons, covers, images, lights, numbers, selects, sensors, switches, and weathers
+ ### State-based template binary sensors, buttons, covers, images, lights, numbers, selects, sensors, switches, and weather entities

104-104: Grammar: replace “weathers” with “weather entities” in heading
Use consistent terminology across headings and configuration reference sections.

- ### Trigger-based template binary sensors, images, lights, numbers, selects, sensors, switches, and weathers
+ ### Trigger-based template binary sensors, images, lights, numbers, selects, sensors, switches, and weather entities
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0d22b7 and 1c344c0.

📒 Files selected for processing (1)
  • source/_integrations/template.markdown (3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/template.markdown

49-49: Link fragments should be valid
null

(MD051, link-fragments)


60-60: Lists should be surrounded by blank lines
null

(MD032, blanks-around-lists)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

@@ -46,18 +46,18 @@ related:

The `template` integration allows creating entities which derive their values from other data. This is done by specifying [templates](/docs/configuration/templating/) for properties of an entity, like the name or the state.

Sensors, binary (on/off) sensors, buttons, images, numbers, and selects are covered on this page. They can be configured using [UI](#configuration) or [YAML](#yaml-configuration) file.
Sensors, binary (on/off) sensors, buttons, images, numbers, selects, and switches are covered on this page. They can be configured using [UI](#configuration) or [YAML](#yaml-configuration) file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Broken link fragment: UI likely broken
The anchor #configuration does not match any heading ID in this document. The include at line 64 generates a “Configuration flow” section, which likely uses #configuration-flow. Please update the link to the correct fragment (or adjust the heading) to prevent a dead link.

- They can be configured using [UI](#configuration) or [YAML](#yaml-configuration) file.
+ They can be configured using [UI](#configuration-flow) or [YAML](#yaml-configuration) file.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Sensors, binary (on/off) sensors, buttons, images, numbers, selects, and switches are covered on this page. They can be configured using [UI](#configuration) or [YAML](#yaml-configuration) file.
Sensors, binary (on/off) sensors, buttons, images, numbers, selects, and switches are covered on this page. They can be configured using [UI](#configuration-flow) or [YAML](#yaml-configuration) file.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

49-49: Link fragments should be valid
null

(MD051, link-fragments)

@zweckj zweckj merged commit 8ce65ce into home-assistant:next Apr 30, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants