-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Restore missing ESPHome docs #38823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore missing ESPHome docs #38823
Conversation
This section was lost in a merge conflict resolution of current -> next
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the ESPHome integration in Home Assistant has been updated to include a new section on "Reconfiguration and Device Replacement." This addition describes procedures for updating device settings post-setup, particularly when replacing devices or resolving name conflicts. It introduces a "Name Conflict Resolution" feature with two resolution options: "Migrate" and "Overwrite." The section outlines requirements for this process and lists scenarios in which name conflict resolution can be triggered. No changes were made to existing functionality or code; only documentation content was added. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant ESPHomeDevice
User->>HomeAssistant: Initiate device replacement or reconfiguration
HomeAssistant->>ESPHomeDevice: Detect new device with same name
ESPHomeDevice-->>HomeAssistant: Respond with device information
HomeAssistant->>User: Trigger Name Conflict Resolution dialog
alt User selects "Migrate"
HomeAssistant->>ESPHomeDevice: Transfer entity configuration and history
else User selects "Overwrite"
HomeAssistant->>ESPHomeDevice: Replace old configuration, erase history
end
HomeAssistant->>User: Confirm resolution complete
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
source/_integrations/esphome.markdown (5)
218-223
: Clarify “Name Conflict Resolution” introductionThe description correctly introduces the Name Conflict Resolution process. To improve clarity:
- Consider linking “Name Conflict Resolution” to a unique anchor for easy referencing (e.g.,
{% anchor name="name-conflict-resolution" %}
).- Move the sentence “This process gives you two options:” directly under the “### Name Conflict Resolution” header for tighter flow.
224-230
: Refine option bullets and caution stylingThe Migrate and Overwrite options are well-described. A few tweaks:
- Add an Oxford comma in the caution text: “entity names, customizations, and history will be lost.”
- Consider using a
{% warning %}
callout for the Overwrite caution to make it stand out visually.🧰 Tools
🪛 LanguageTool
[style] ~226-~226: Consider using a different adverb to strengthen your wording.
Context: ...ost. Use this only if the new device is completely different and you don’t need anything f...(COMPLETELY_ENTIRELY)
[uncategorized] ~226-~226: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...f the new device is completely different and you don’t need anything from the previo...(COMMA_COMPOUND_SENTENCE)
234-240
: Streamline requirement phrasingThe Requirements section is clear but can be more concise:
- Change “To trigger Name Conflict Resolution, all of the following must be true:” to “To trigger Name Conflict Resolution, all the following must be true:”.
- Optionally, wrap these bullets in an
{% note %}
admonition to highlight their importance.🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Consider removing “of” to be more concise
Context: ...n To trigger Name Conflict Resolution, all of the following must be true: - The new devi...(ALL_OF_THE)
244-251
: Unify UI terminology in trigger listIn the trigger list, item 248 mentions “repair flow” while item 249 refers to “Reconfigure” in the UI. For consistency, use the same term throughout (e.g., change “repair flow” → “Reconfigure flow” to match the UI label).
257-257
: Ensure single trailing newlineThe file should end with exactly one newline character to satisfy markdownlint (MD047). Please add or trim the final newline accordingly.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
257-257: Files should end with a single newline character
null(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/esphome.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/esphome.markdown
[style] ~226-~226: Consider using a different adverb to strengthen your wording.
Context: ...ost. Use this only if the new device is completely different and you don’t need anything f...
(COMPLETELY_ENTIRELY)
[uncategorized] ~226-~226: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...f the new device is completely different and you don’t need anything from the previo...
(COMMA_COMPOUND_SENTENCE)
[style] ~236-~236: Consider removing “of” to be more concise
Context: ...n To trigger Name Conflict Resolution, all of the following must be true: - The new devi...
(ALL_OF_THE)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/esphome.markdown
257-257: Files should end with a single newline character
null
(MD047, single-trailing-newline)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/esphome.markdown (1)
214-218
: Verify new section placement and sidebar navigationThe new “Reconfiguration and Device Replacement” section is a valuable addition, but please ensure it’s included in the integration’s documentation sidebar or summary file so users can discover it easily. Also confirm that its heading level (
##
) aligns with the surrounding sections for consistency.
thanks |
Proposed change
This section was lost in a merge conflict resolution of current -> next
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit