Skip to content

Add scene platform to Qbus integration #38836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

thomasddn
Copy link
Contributor

@thomasddn thomasddn commented May 1, 2025

Proposed change

Adds documentation for the scene platform.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated Qbus integration documentation to include support for the "Scene" entity type.
    • Expanded details on available entities, describing the "Scene" entity.
    • Removed references to "Toggle" and "Dimmer" device types from supported devices.
    • Added example automations demonstrating how to activate and extend Qbus scenes.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels May 1, 2025
Copy link

netlify bot commented May 1, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 0f8c51c
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/681476a0364af200083a219d
😎 Deploy Preview https://deploy-preview-38836--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented May 1, 2025

📝 Walkthrough

Walkthrough

The documentation for the Qbus integration was updated to reflect support for the "Scene" entity type. The list of supported Home Assistant categories and platforms now includes "Scene," and the "Available entities" section describes the functionality of the "Scene" entity. The documentation also removes references to "Toggle" and "Dimmer" device types under supported devices. Additionally, two example automations demonstrating the use of Qbus scenes were added. No code or functional changes were made.

Changes

File(s) Change Summary
source/_integrations/qbus.markdown Updated documentation to add "Scene" entity support, revise supported entities, remove "Toggle" and "Dimmer" device types, and add example automations for scene activation.

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to documentation updates.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/qbus.markdown (1)

50-50: Enhance description for Scene entity.
The entry “activates scenes” is accurate but brief—consider expanding it with a short example or clarifying that this entity triggers predefined Qbus scenes within Home Assistant.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59a34bd and d277eb5.

📒 Files selected for processing (1)
  • source/_integrations/qbus.markdown (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/qbus.markdown (2)

7-7: Add Scene to integration categories.
The new “Scene” category is correctly inserted in alphabetical order under ha_category to reflect the feature addition.


12-12: Add scene platform to supported platforms.
Lowercase scene aligns with Home Assistant’s platform naming conventions under ha_platforms. Ensure any downstream examples or schema validations include this new platform.

@thomasddn thomasddn marked this pull request as draft May 1, 2025 11:45
@thomasddn thomasddn marked this pull request as ready for review May 2, 2025 07:39
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20db668 and 0f8c51c.

📒 Files selected for processing (1)
  • source/_integrations/qbus.markdown (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/qbus.markdown (2)

7-12: Scene added to integration metadata
The new ha_category entry - Scene and ha_platforms entry - scene correctly document the Scene platform support. The entries are in alphabetical order and comply with the front matter schema.


48-52: Document Scene entity in Available entities
The - **Scene**: activates predefined scenes entry accurately describes the new Scene entity. This aligns well with the new feature and follows the existing style.

Comment on lines +95 to +127
### Extend Qbus scene

You can extend a Qbus scene by adding other entities in an automation.
In this example, a LED strip is turned on when the **Watching TV** Qbus scene is activated.

Replace `scene.ctd_000001_watching_tv` with your Qbus scene entity and `light.tv_strip` with your light entity.

{% raw %}

```yaml
alias: Extend "Watching TV" Qbus scene
description: ""
triggers:
- trigger: state
entity_id:
- scene.ctd_000001_watching_tv
conditions: []
actions:
- action: light.turn_on
metadata: {}
data:
rgb_color:
- 255
- 187
- 0
brightness_pct: 40
target:
entity_id: light.tv_strip
mode: single
```

{% endraw %}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Update second automation example to use correct HA automation schema
Similarly, refactor the second example to use singular trigger: and the action: list with service:. For example:

@@ triggers:
- triggers:
-   - trigger: state
-     entity_id:
-       - scene.ctd_000001_watching_tv
+ trigger:
+   - platform: state
+     entity_id: scene.ctd_000001_watching_tv

@@ actions:
- actions:
-   - action: light.turn_on
-     metadata: {}
-     data:
-       rgb_color:
-         - 255
-         - 187
-         - 0
-       brightness_pct: 40
-     target:
-       entity_id: light.tv_strip
+ action:
+   - service: light.turn_on
+     target:
+       entity_id: light.tv_strip
+     data:
+       rgb_color: [255, 187, 0]
+       brightness_pct: 40
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### Extend Qbus scene
You can extend a Qbus scene by adding other entities in an automation.
In this example, a LED strip is turned on when the **Watching TV** Qbus scene is activated.
Replace `scene.ctd_000001_watching_tv` with your Qbus scene entity and `light.tv_strip` with your light entity.
{% raw %}
```yaml
alias: Extend "Watching TV" Qbus scene
description: ""
triggers:
- trigger: state
entity_id:
- scene.ctd_000001_watching_tv
conditions: []
actions:
- action: light.turn_on
metadata: {}
data:
rgb_color:
- 255
- 187
- 0
brightness_pct: 40
target:
entity_id: light.tv_strip
mode: single
```
{% endraw %}

Comment on lines +63 to +93
## Examples

### Automation to activate Qbus scene

This automation will activate the **Watching TV** Qbus scene when turning on your TV.

Replace `media_player.my_tv` with your TV entity and `scene.ctd_000001_watching_tv` with your Qbus scene entity.

{% raw %}

```yaml
alias: Activate TV scene when turning on TV
description: ""
mode: single
triggers:
- entity_id:
- media_player.my_tv
from: "off"
to: "on"
trigger: state
conditions: []
actions:
- target:
entity_id: scene.ctd_000001_watching_tv
metadata: {}
alias: Activate TV scene
action: scene.turn_on
data: {}
```

{% endraw %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Update first automation example to use correct HA automation schema
The example should use singular trigger: with platform: state and to: fields, and the action: list should use service: rather than action:.
Here’s a diff for the first example:

@@ triggers:
- triggers:
-   - entity_id:
-       - media_player.my_tv
-     from: "off"
-     to: "on"
-     trigger: state
+ trigger:
+   - platform: state
+     entity_id: media_player.my_tv
+     to: 'on'

@@ conditions: []
- conditions: []
+ condition: []

@@ actions:
- actions:
-   - target:
-       entity_id: scene.ctd_000001_watching_tv
-     metadata: {}
-     alias: Activate TV scene
-     action: scene.turn_on
-     data: {}
+ action:
+   - service: scene.turn_on
+     target:
+       entity_id: scene.ctd_000001_watching_tv
+     data: {}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Examples
### Automation to activate Qbus scene
This automation will activate the **Watching TV** Qbus scene when turning on your TV.
Replace `media_player.my_tv` with your TV entity and `scene.ctd_000001_watching_tv` with your Qbus scene entity.
{% raw %}
```yaml
alias: Activate TV scene when turning on TV
description: ""
mode: single
triggers:
- entity_id:
- media_player.my_tv
from: "off"
to: "on"
trigger: state
conditions: []
actions:
- target:
entity_id: scene.ctd_000001_watching_tv
metadata: {}
alias: Activate TV scene
action: scene.turn_on
data: {}
```
{% endraw %}
alias: Activate TV scene when turning on TV
description: ""
mode: single
trigger:
- platform: state
entity_id: media_player.my_tv
to: 'on'
condition: []
action:
- service: scene.turn_on
target:
entity_id: scene.ctd_000001_watching_tv
data: {}

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @thomasddn 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants