-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add Luma embed for Community Day events & facade iframes #38845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8c4e227
Add Luma embed
mrdarrengriffin 9eae956
Prevent auto loading
mrdarrengriffin eeb2655
Add general iframe facade logic
mrdarrengriffin 5e43883
Remove comment
mrdarrengriffin 295b230
Only load for the first event fired
mrdarrengriffin 1b1e88e
Set lightmode and increase iframe height
mrdarrengriffin bc85ef4
Remove logic around iframe facade
mrdarrengriffin 8ee9c1e
Change count text
mrdarrengriffin 1e68ee5
Reword content, remove events
mrdarrengriffin 295d32d
Change content
mrdarrengriffin cf1f0a8
Rephrase
mrdarrengriffin f14dcf8
Merge branch 'current' into add-luma-embed
mrdarrengriffin 33fddea
Add variable scopes
balloob 50b8502
Update source/_includes/javascripts/scripts.html
balloob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve iframe accessibility and markup hygiene
title
attribute (e.g.title="Home Assistant Community Day Calendar"
) for screen readers.frameborder="0"
—rely on CSS for styling (you already haveborder: 1px solid …
).loading="lazy"
on the<iframe>
; your JS will still swapdata-src
, and browsers that support lazy loading will handle it natively.