-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add siren groups to Documentation #38856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough""" WalkthroughThe documentation for the "group" integration was updated to reflect the addition of support for the "siren" entity domain. This includes updating lists and descriptions to mention sirens among the supported entity types, as well as providing a new example configuration for grouping siren entities. No changes were made to the actual code or to the declarations of public entities; all modifications are limited to documentation. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User->>Documentation: Reads about group integration
Documentation-->>User: Shows updated list including "siren"
User->>Documentation: Views example YAML for siren group
Documentation-->>User: Provides siren group configuration example
""" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/group.markdown
(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/group.markdown (3)
17-17
: Add ‘Siren’ to supported HA categories
The new- Siren
entry underha_category
correctly aligns with the feature addition. Placement afterSensor
and beforeSwitch
follows the existing ordering.
37-37
: Include siren inha_platforms
Adding- siren
underha_platforms
ensures that the siren domain is recognized by the group integration. The alphabetical placement betweensensor
andswitch
is correct.
53-53
: List siren in the grouped entities list
The new line- [siren (sirens)](/integrations/siren/)
correctly mirrors the format of other entries and points to the right documentation URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @MarzyCoder 👍
Thank you for contributing, @MarzyCoder 💪 For future PRs, please don't alter the PR template. You can just add the link to the core PR under "Link to parent pull request in the codebase". and leave the rest as is, even if you don't have a related brand PR or issue. |
Thanks for the notice! I will definitely keep that in mind for future PRs! |
Proposed change
Adding siren groups to the documentation. (home-assistant/core#144069)
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit