-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update WMS WebControl pro button and cover documentation #38857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough""" WalkthroughThe documentation for the WMS WebControl pro integration was updated to reflect support for a new device category: buttons. The changes include listing "button" as a supported platform, adding a section describing button devices, updating device category references, and clarifying the description of cover devices to specify roller shutters/blinds and other supported covers. No code or API signatures were modified; all changes are limited to documentation. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are documentation-only and do not affect control flow or introduce new features in the codebase. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/wmspro.markdown (3)
35-35
: Improve cross-reference formatting
Consider adding an Oxford comma for consistency in the list:
- Current:
[buttons](#buttons), [covers](#covers), [lights](#lights) and [scenes](#scenes)
- Suggested:
[buttons](#buttons), [covers](#covers), [lights](#lights), and [scenes](#scenes)
41-44
: Add and document 'Buttons' section
Great to see the new "Buttons" section describing identification-capable devices. For consistency with Home Assistant style, consider adding a comma after "e.g." and clarifying punctuation:- (e.g. winking an awning or blinking a light) + (e.g., winking an awning or blinking a light)
48-49
: Clarify roller shutter/blind terminology
The phrase "roller shutters/blinds" could be clearer. Consider using "roller shutters and blinds" or "roller shutters or blinds" to avoid the slash notation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/wmspro.markdown
(3 hunks)
🔇 Additional comments (2)
source/_integrations/wmspro.markdown (2)
5-5
: Add 'Button' toha_category
metadata
Including "Button" in the Home Assistant category list aligns the documentation with the new platform support.
17-17
: Include 'button' inha_platforms
Registering "button" in the platforms list ensures that the new button entities are discoverable in the docs and UI.
Proposed change
Enhance documentation regarding button and cover support.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit