Skip to content

Update statistics-graph.markdown #38859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

jackjourneyman
Copy link
Contributor

@jackjourneyman jackjourneyman commented May 3, 2025

Clarify which sensors support long-term statistics

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Updated the description of how statistics are collected and retained, clarifying that statistics are gathered every 5 minutes and hourly only for sensors with specific state classes (measurement, total, or total_increasing). Retention details and types of statistics remain unchanged.

Clarify which sensors support long-term statistics
@home-assistant home-assistant bot added the current This PR goes into the current branch label May 3, 2025
Copy link

netlify bot commented May 3, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 05d5cf8
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6815f08a3424120008771664
😎 Deploy Preview https://deploy-preview-38859--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented May 3, 2025

📝 Walkthrough

Walkthrough

The documentation for statistics gathering and retention was updated to clarify that statistics are collected every 5 minutes and hourly only for sensors with a state_class of measurement, total, or total_increasing. The previous description was more general, simply stating that statistics were gathered for sensors that support it. Details about retention periods and types of statistics collected were not changed.

Changes

File Change Summary
source/_dashboards/statistics-graph.markdown Updated documentation to specify that statistics collection applies only to sensors with certain state_class values. Other descriptions remain unchanged.

Sequence Diagram(s)

No sequence diagram is generated as the change is limited to documentation clarification.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_dashboards/statistics-graph.markdown (1)

25-25: Improve clarity and punctuation in statistics description

  • Add an Oxford comma: change measurement, total or total_increasingmeasurement, total, or total_increasing.
  • Simplify phrasing: replace “every 5 minutes and also hourly” with “every 5 minutes and hourly”.
  • Break the last sentence into two for better readability:
    • For sensors: record the <abbr title="Minimum">min</abbr>, <abbr title="Maximum">max</abbr>, and <abbr title="Average">mean</abbr> values each hour.
    • For metered entities: record the <abbr title="Total">sum</abbr>.

Proposed diff:

-Statistics are gathered every 5 minutes and also hourly for sensors with a state_class of measurement, total or total_increasing. The 5-minute statistics will be retained for the duration set in the [recorder configuration](/integrations/recorder/#purge_keep_days), and hourly statistics will be retained indefinitely. It will either keep the <abbr title="Minimum">`min`</abbr>, <abbr title="Maximum">`max`</abbr>, and <abbr title="Average">`mean`</abbr> of a sensor's value for a specific hour or the <abbr title="Total">`sum`</abbr> for a metered entity.
+Statistics are gathered every 5 minutes and hourly for sensors with a `state_class` of `measurement`, `total`, or `total_increasing`. The 5-minute statistics are retained for the duration set in the [recorder configuration](/integrations/recorder/#purge_keep_days), and hourly statistics are retained indefinitely.
+
+For sensors, the <abbr title="Minimum">`min`</abbr>, <abbr title="Maximum">`max`</abbr>, and <abbr title="Average">`mean`</abbr> values are recorded each hour. For metered entities, the <abbr title="Total">`sum`</abbr> is recorded.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 696a1f3 and 05d5cf8.

📒 Files selected for processing (1)
  • source/_dashboards/statistics-graph.markdown (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_dashboards/statistics-graph.markdown (1)

25-25: Verify recorder configuration link anchor

Please confirm that the fragment #purge_keep_days correctly matches the recorder integration’s documentation anchor. It might be #purge-keep-days instead.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jackjourneyman 👍

@c0ffeeca7 c0ffeeca7 merged commit e44b153 into home-assistant:current May 5, 2025
7 checks passed
@jackjourneyman jackjourneyman deleted the patch-2 branch May 5, 2025 09:48
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants