Skip to content

Provide detailed functionality description for APCUPSD #38876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

yuxincs
Copy link
Contributor

@yuxincs yuxincs commented May 4, 2025

Proposed change

This PR provides a detailed functionality description for all sensors of the APC UPS Daemon integration. The information is obtained from the following sources:

I try my best to provide accurate information. However, the "available for machines" information cannot be easily obtained.
So I had to do some simple inference:

  • I only have a basic Back-UPS series UPS, so I'm assuming all entities provided by the basic model to be available for "all".
  • The Back-UPS Pro and Smart-UPS series are obtained and inferred from https://linux.die.net/man/8/apcaccess.

If there are user reports for inaccuracies in the future we can further improve it.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Expanded and restructured the APC UPS Daemon integration documentation to provide detailed descriptions, availability, and notes for all supported binary sensors and sensors. The new format offers a comprehensive, user-friendly reference for all entities and their characteristics.

@home-assistant home-assistant bot added the current This PR goes into the current branch label May 4, 2025
Copy link

netlify bot commented May 4, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 0fedd75
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/68178da4ea74bb00084a718b
😎 Deploy Preview https://deploy-preview-38876--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented May 4, 2025

📝 Walkthrough

Walkthrough

The documentation for the APC UPS Daemon integration was rewritten and expanded. The update replaces a brief list of binary sensors and sensors with a detailed section that enumerates all entities provided by the integration, categorizing them as binary sensors and sensors. Each entity now includes a description, availability details specifying supported UPS models, and additional remarks where relevant. The documentation now serves as a comprehensive reference for users, outlining all supported entities and their characteristics.

Changes

File(s) Change Summary
source/_integrations/apcupsd.markdown Rewrote and expanded documentation: replaced brief sensor lists with detailed entity catalog, descriptions, and availability notes. No code changes.

Sequence Diagram(s)

No sequence diagram generated as the changes are documentation-only.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
source/_integrations/apcupsd.markdown (1)

59-64: Verify binary sensor coverage and naming
Only Online Status is listed here. Ensure that this matches the actual binary_sensor.apcupsd_online_status entity key generated by the integration. Consider whether additional binary states (for example, UPS on-battery vs. on-line) should be exposed or documented to cover common use cases.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 772048b and 0fedd75.

📒 Files selected for processing (1)
  • source/_integrations/apcupsd.markdown (1 hunks)
🔇 Additional comments (2)
source/_integrations/apcupsd.markdown (2)

53-56: Consistent section headings and overview
The new "Supported functionality" and "Entities" headings align with Home Assistant documentation conventions. The introductory line clearly explains the scope of the section.


65-71: Review Sensors heading and note formatting
The "Sensors" subheading and {% note %} block are clear and helpful. Please verify that the note renders correctly in the site build and that the path for enabling advanced sensors ("Settings → Devices & Services → Entities → Advanced settings") remains accurate in the latest UI.

Comment on lines +73 to +363
- **Description**: The date and time of last transfer off battery since apcupsd startup.
- **Available for machines**: Smart-UPS

- **Ambient Humidity**
- **Description**: The humidity as measured by the UPS.
- **Available for machines**: Smart-UPS with optional accessories (e.g., temperature/humidity sensors or SNMP network cards).

- **Ambient Temperature**
- **Description**: The ambient temperature as measured by the UPS.
- **Available for machines**: Smart-UPS with optional accessories (e.g., temperature/humidity sensors or SNMP network cards).

- **Status Data**
- **Description**: Header record indicating the STATUS format revision level, the number of records that follow the APC statement, and the number of bytes that follow the record.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Model**
- **Description**: The old APC model identification code.
- **Available for machines**: Smart-UPS
- **Remarks**: Disabled by default for advanced uses.

- **Cable Type**
- **Description**: The cable as specified in the configuration file (UPSCABLE).
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Status Date**
- **Description**: The date and time that the information was last obtained from the UPS.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Driver**
- **Description**: The driver used to communicate with the UPS.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Firmware Version**
- **Description**: The firmware revision number as reported by the UPS.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Hostname**
- **Description**: The name of the machine that collected the UPS data.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Last Transfer**
- **Description**: The reason for the last transfer to batteries.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Manufacture Date**
- **Description**: The date the UPS was manufactured.
- **Available for machines**: Smart-UPS
- **Remarks**: Disabled by default for advanced uses.

- **Model**
- **Description**: The UPS model as derived from information from the UPS.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Register 1 Fault**
- **Description**: The value from the UPS fault register 1.
- **Available for machines**: Smart-UPS
- **Remarks**: Disabled by default for advanced uses.

- **Register 2 Fault**
- **Description**: The value from the UPS fault register 2.
- **Available for machines**: Smart-UPS
- **Remarks**: Disabled by default for advanced uses.

- **Register 3 Fault**
- **Description**: The value from the UPS fault register 3.
- **Available for machines**: Smart-UPS
- **Remarks**: Disabled by default for advanced uses.

- **Sensitivity**
- **Description**: The sensitivity level of the UPS to line voltage fluctuations.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Serial Number**
- **Description**: The UPS serial number.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Status Flag**
- **Description**: Status flag. English version is given by STATUS.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Name**
- **Description**: The name of the UPS as stored in the EEPROM or in the UPSNAME directive in the configuration file.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.

- **Daemon Info**
- **Description**: The apcupsd release number, build date, and platform.
- **Available for machines**: all
- **Remarks**: Disabled by default for advanced uses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Resolve duplicate sensor names and improve grouping
The sensors list includes two entries named Transfer from Battery (lines 174–177 & 263–266) and two named Model (lines 280–283 & 320–323). Duplicate names will confuse users and may not map to unique entity IDs. Please rename or qualify these entries (e.g., "Last Transfer from Battery" vs. "Transfer from Battery (Smart-UPS)", "UPS Model" vs. "Legacy Model") and consider grouping sensors under subheadings by machine type (all, Back-UPS Pro, Smart-UPS) to reduce repetition and improve readability.

Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yuxincs 👍

@c0ffeeca7 c0ffeeca7 merged commit 16a2465 into home-assistant:current May 5, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants