-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add switch entity #38880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add switch entity #38880
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe Zimi integration documentation was updated to reflect that the 1-, 2-, 3-, and 4-button Multi-Purpose Switch devices are now supported, changing their status from "Future" to "Yes." The Power Point device remains marked as "Future," with only a formatting adjustment made to its documentation. Additionally, a new section describing the Zimi switch controller and its on/off functionality was added, providing further clarification on supported features. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
User->>Documentation: Reads Zimi integration docs
Documentation-->>User: Shows updated device support status
Documentation-->>User: Provides details on switch controller functionality
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Note that "Power Point" is a generic term for an electrical outlet in Australia and is the product name these devices in the Zimi literature. It is not a Microsoft product. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @markhannon 👍
apologies, I found another nitpick. Please add switch to the header, under lines 11 and 14. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/zimi.markdown (1)
86-86
: Table formatting: Add a space for consistency.
Most rows use a leading space after the pipe delimiter. For consistency, update line 86 to:-|Power Point | Outlet | 2xOutlet | Outlet {Name} | Future | +| Power Point | Outlet | 2xOutlet | Outlet {Name} | Future |🧰 Tools
🪛 LanguageTool
[grammar] ~86-~86: Did you mean “PowerPoint” (= Microsoft presentation software)?
Context: ... {Name}
Switch {Name} | Yes | |Power Point | Outlet |...(MICROSOFT_PRODUCTS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/zimi.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/zimi.markdown
[grammar] ~86-~86: Did you mean “PowerPoint” (= Microsoft presentation software)?
Context: ... {Name}
Switch {Name} | Yes | |Power Point | Outlet |...
(MICROSOFT_PRODUCTS)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/zimi.markdown (2)
82-85
: Table updates: Verified Multi-Purpose Switch support status changed from "Future" to "Yes".
The new rows for the 1–4 button Multi-Purpose Switch devices follow the existing table pattern and accurately reflect supported entities.
92-95
: Section addition: Zimi switch controller documented correctly.
The new "Zimi switch controller" section aligns with the existing "Zimi light controller" format and clearly describes the basic on/off functionality.
Proposed change
Add switch entity to documentation.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit