-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update cover.markdown #38889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cover.markdown #38889
Conversation
Added mention of [roller shutters](https://en.wikipedia.org/wiki/Roller_shutter) which are listed in to intro text, but missing from the actually relevant device class (see home-assistant#37704).
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough""" WalkthroughThe description for the "shutter" device class in the cover integration documentation was expanded to clarify that shutters can also be raised or lowered, explicitly including roller shutters, in addition to the previously described swinging and tilting types. Changes
Sequence Diagram(s)No sequence diagram generated, as the change is limited to documentation updates. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/cover.markdown (1)
61-61
: Fix verb form for clarity.The phrase "to covering an opening" is grammatically incorrect and should read "to cover an opening".
Apply this diff:- **shutter**: Control of shutters, which are linked slats that can be raised or lowered to cover an opening, such as window or door roller shutters, or that swing out/in to covering an opening or may be tilted for partial cover, such as indoor or exterior window shutters. + **shutter**: Control of shutters, which are linked slats that can be raised or lowered to cover an opening, such as window or door roller shutters, or that swing out/in to cover an opening or may be tilted for partial cover, such as indoor or exterior window shutters.🧰 Tools
🪛 LanguageTool
[uncategorized] ~61-~61: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...oller shutters, or that swing out/in to covering an opening or may be tilted for partial...(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/cover.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/cover.markdown
[uncategorized] ~61-~61: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...oller shutters, or that swing out/in to covering an opening or may be tilted for partial...
(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
Fix incorrect wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mithomas 👍
Proposed change
Added mention of roller shutters which are listed in to intro text, but missing from the actually relevant device class (see #37704).
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit