-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Areas and floors: add links and glossary refs #38903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Warning Rate limit exceeded@c0ffeeca7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 9 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughGlossary entries for "Area," "Category," "Floor," and "Label" were updated to include hyperlinks to Home Assistant's organizing documentation. The "Floor" and "Label" entries also received direct Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation and glossary formatting without affecting control flow or feature logic. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_docs/organizing/areas.markdown (1)
50-50
: Remove unnecessary comma before “if”
According to our style conventions, avoid a comma before “if” in this context.
Apply this diff:-3. In the dialog, select the {% term floor %} and add {% term labels %}, if you like. +3. In the dialog, select the {% term floor %} and add {% term labels %} if you like.🧰 Tools
🪛 LanguageTool
[typographical] ~50-~50: Usually, there’s no comma before “if”.
Context: ... term floor %} and add {% term labels %}, if you like. ## Assigning an area to mult...(IF_NO_COMMA)
source/_docs/organizing/floors.markdown (1)
44-44
: Normalize term tag casing for “automations”
The current tag uses uppercase:{% term Automations %}
. For consistency with other references, it should be lowercase:-{% term Automations %} and {% term scripts %} or voice assistants … +{% term automations %} and {% term scripts %} or voice assistants …source/_data/glossary.yml (1)
117-124
: Add missing link for “Category”
A link field is needed for Category to mirror other grouping terms.
Suggested diff:- term: Category definition: >- A category is an organization tool ... aliases: - categories + link: /docs/organizing/categories/
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
source/_data/glossary.yml
(6 hunks)source/_docs/organizing/areas.markdown
(3 hunks)source/_docs/organizing/floors.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_docs/organizing/areas.markdown
[typographical] ~50-~50: Usually, there’s no comma before “if”.
Context: ... term floor %} and add {% term labels %}, if you like. ## Assigning an area to mult...
(IF_NO_COMMA)
🔇 Additional comments (9)
source/_docs/organizing/areas.markdown (3)
21-21
: Consistent templated term usage for “floors”
Good replacement of the plain word “floors” with{% term floors %}
to leverage the glossary term and ensure consistent styling and linking.
32-32
: Verified external link to floor creation
The link to create a new floor (/docs/organizing/floors/#creating-a-floor
) is correct and matches the organizing documentation.
46-46
: Templated term tag for “floor” applied correctly
Replacing the plain “floor” with{% term floor %}
aligns with the glossary and maintains consistency.source/_docs/organizing/floors.markdown (3)
16-16
: Approve templated term usage for “areas”
Using{% term areas %}
here correctly links back to the glossary entry for areas.
18-18
: Approve templated term usage for automations, scripts, actions
All three terms ({% term automations %}
,{% term scripts %}
,{% term actions %}
) are correctly applied and consistent.
51-51
: Approve templated tag for downstream updates
The{% term automations %}
and{% term scripts %}
tags here are correctly lowercased and link to their glossary entries.source/_data/glossary.yml (3)
45-54
: Approve addition of link for “Area”
The new hyperlink (/docs/organizing/areas/
) in the Area entry is accurate and aligns with the documentation changes.
271-288
: Approve addition of link for “Floor”
The link (/docs/organizing/floors/
) is correctly added to the Floor entry, enabling the glossary to point to the new organizing page.
413-430
: Approve addition of link for “Label”
The link (/docs/organizing/labels/
) is correctly inserted, completing the cross-reference for labels.
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit