-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Zimi: Add fan details #38905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Zimi: Add fan details #38905
Conversation
Add extra categories Add related
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Zimi integration was updated to include "Fan" as a category and platform alongside "Light." A related URL to the Zimi website was added. The device support table was updated to show the "Fan and Light Controller" as supported, and a new section describing the fan controller's capabilities was added. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Zimi Integration Documentation
User->>Zimi Integration Documentation: Reads updated metadata and device support
User->>Zimi Integration Documentation: Views new section on Fan controller
Zimi Integration Documentation-->>User: Provides details on supported devices and fan entity capabilities
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hi there, @markhannon 👋 Please fill out the PR template and under Link to parent pull request in the codebase:, provide the link to the related core PR. |
Sorry about all the noise I am generating ... anxious to get all of the various parts of this integration in play. |
no stress. I was trying to help, not complaining |
usually, you need to create a separate docs PR for each core PR. So the switch documentation should go in a separate PR, normally. home-assistant/core#144236. So that when your code PR is merged, the related docs can be merged with it. |
I am probably trying to move too fast and launch parallel PR's rather than waiting for the entities to be merged. I can mark that future PR's as draft for the moment |
Proposed change
Add fan details
Add a few other improvements
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
Summary by CodeRabbit