-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add sensor #38906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add sensor #38906
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Zimi Cloud Controller integration was updated to reflect expanded device support. New device categories (Switch, Fan, Sensor) were added, support statuses in tables were revised, and new descriptive sections for these devices were included. A related URL was also added. No code or logic changes occurred. Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to documentation updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/zimi.markdown (1)
96-96
: Ensure consistent section heading naming.
Consider aligning the sensor section heading with the others—either add “controller” (e.g.,### Zimi sensor controller
) or drop “controller” from fan/switch/light headings for consistency.Also applies to: 104-104, 108-108
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/zimi.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/zimi.markdown
[grammar] ~94-~94: Did you mean “PowerPoint” (= Microsoft presentation software)?
Context: ...{Name}
Switch {Name} | Yes | | Power Point | Outlet | ...
(MICROSOFT_PRODUCTS)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (8)
source/_integrations/zimi.markdown (8)
12-14
: Add new device categories in front matter.
The updatedha_category
now correctly reflects the additional device types supported by this integration.
18-20
: Add new platforms in front matter.
Theha_platforms
list has been expanded to includeswitch
,fan
, andsensor
to match the newly supported entities.
24-25
: Add related URL to integration metadata.
Including therelated
link to the official Zimi website provides useful context for users seeking more information.
85-94
: Update device support table with new entries and statuses.
The table now accurately reflects support for the Fan and Light Controller, expands Garage Door Controller support to include sensors, and adds all Multi-Purpose Switch variants along with the Power Point outlet. Formatting (including<br>
tags) is consistent with existing table cells.🧰 Tools
🪛 LanguageTool
[grammar] ~94-~94: Did you mean “PowerPoint” (= Microsoft presentation software)?
Context: ...{Name}
Switch {Name} | Yes | | Power Point | Outlet | ...(MICROSOFT_PRODUCTS)
94-94
: Verify product name formatting.
LanguageTool flagged “Power Point” as a possible typo (it suggested “PowerPoint”), but here it refers to an electrical outlet. Please confirm that “Power Point” matches the official Zimi product branding.🧰 Tools
🪛 LanguageTool
[grammar] ~94-~94: Did you mean “PowerPoint” (= Microsoft presentation software)?
Context: ...{Name}
Switch {Name} | Yes | | Power Point | Outlet | ...(MICROSOFT_PRODUCTS)
96-96
: Add Zimi fan controller section.
The new### Zimi fan controller
heading properly introduces the fan-specific entity details.
104-104
: Add Zimi sensor section.
The### Zimi sensor
heading and description correctly document the sensor entity’s capabilities.
108-108
: Add Zimi switch controller section.
The### Zimi switch controller
heading is now in place to describe basic on/off switch entities.
Proposed change
Add sensor details
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit