-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Rename S3 integration also in the release blog #38908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @edenhaus 👍
Release blog post is not part of the next branch and therefore missed on the first rename |
📝 WalkthroughWalkthroughThe release notes markdown file was updated to rename the integration from "S3" to "AWS S3." The description now specifies support exclusively for Amazon S3 storage buckets, removing references to generic S3-compatible providers. All related references and links were updated to reflect the new naming. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_posts/2025-05-07-release-20255.markdown
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_posts/2025-05-07-release-20255.markdown (1)
284-285
: Confirm rename and description update for the integration
The change correctly renames the “S3” integration to “AWS S3” and updates its description to explicitly reference Amazon S3 storage buckets. This aligns with our new naming convention and removes ambiguity around other S3-compatible providers.
@@ -300,7 +299,7 @@ To process: | |||
[Miele]: /integrations/miele | |||
[ntfy.sh]: https://ntfy.sh/ | |||
[ntfy]: /integrations/ntfy | |||
[S3]: /integrations/s3 | |||
[AWS S3]: /integrations/aws_s3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify that the AWS S3 integration docs exist at the new path
Please confirm that /integrations/aws_s3
is the correct slug and that the corresponding documentation file is present.
Run the following script to verify the existence of the integration doc:
🏁 Script executed:
#!/bin/bash
# Description: Check for AWS S3 integration documentation under docs/integrations
fd aws_s3 docs/integrations
Length of output: 134
🏁 Script executed:
#!/bin/bash
# Locate any 'integrations' directories
fd -t d integrations
# Find files or directories matching 'aws_s3*'
fd aws_s3*
# Search throughout the repo for references to 'aws_s3'
rg -n 'aws_s3' .
Length of output: 432
🏁 Script executed:
#!/bin/bash
# Search for AWS S3 integration docs under source/integrations and source/_integrations
echo "Files under source/integrations matching 'aws' or 's3':"
fd -t f -i 'aws' source/integrations || true
fd -t f -i 's3' source/integrations || true
echo
echo "Files under source/_integrations matching 'aws' or 's3':"
fd -t f -i 'aws' source/_integrations || true
fd -t f -i 's3' source/_integrations || true
echo
echo "Ripgrep for 'S3' in both directories:"
rg -n 'S3' source/integrations source/_integrations || true
Length of output: 4356
Correct AWS S3 integration link
The current slug /integrations/aws_s3
does not map to any docs. The S3 integration lives in source/_integrations/s3.markdown
, which generates the /integrations/s3
slug. Please update line 302 in source/_posts/2025-05-07-release-20255.markdown
:
-[AWS S3]: /integrations/aws_s3
+[AWS S3]: /integrations/s3
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
[AWS S3]: /integrations/aws_s3 | |
[AWS S3]: /integrations/s3 |
Proposed change
Follow up for #38904
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit