-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add Portainer docs #39268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add Portainer docs #39268
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA new documentation file has been added for the Portainer integration in Home Assistant. This file introduces the integration, provides setup instructions, details its current capabilities, and includes relevant metadata and configuration guidance. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant Portainer
User->>Portainer: Log in and create Access Token
User->>HomeAssistant: Enter Access Token for Portainer integration
HomeAssistant->>Portainer: Connect using Access Token
Portainer-->>HomeAssistant: Provide API access/status
HomeAssistant-->>User: Display Portainer service status (binary sensor)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/portainer.markdown (3)
21-23
: Improve phrasing of the note block
The sentence “More platforms and features will be added in.” reads as incomplete. Consider rephrasing for clarity.{% note %} -This integration is currently being actively developed and tested. More platforms and features will be added in. +This integration is currently being actively developed and tested. More platforms and features will be added in the future. {% endnote %}
36-38
: Fix grammar and hyphenation in the access token instructions
- Change “Goto” to “Go to”
- Hyphenate “top right corner” → “top-right corner”
2. Go to your user profile by clicking on your username in the top-right corner and select `My Account`. -3. Goto the section `Access Tokens`. +3. Go to the section `Access Tokens`.🧰 Tools
🪛 LanguageTool
[uncategorized] ~36-~36: Consider adding a hyphen.
Context: ...ile by clicking on your username in the top right corner and selectMy Account
. 3. Goto...(TOP_LEFT_CORNER)
42-42
: Ensure the file ends with a single newline
Add exactly one trailing newline to satisfy markdownlint’s MD047.{% include integrations/config_flow.md %} +
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
42-42: Files should end with a single newline character
null(MD047, single-trailing-newline)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/portainer.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/portainer.markdown
[uncategorized] ~36-~36: Consider adding a hyphen.
Context: ...ile by clicking on your username in the top right corner and select My Account
. 3. Goto...
(TOP_LEFT_CORNER)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/portainer.markdown
42-42: Files should end with a single newline character
null
(MD047, single-trailing-newline)
Thank you for the new PR, @erwindouna 🙏 in a next step, please fill out the PR template, and also add the link to the related PR in the brands repository (for the logo and icon) |
The logo and brand is already in the brands repo? Or am I overlooking a part? |
just saw that there is another PR open to add the portainer integration. Are you working together? |
Abounded it seemed, whereas Thomas mentioned he didn't have the time to finish it. |
I see. I'll take a look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/portainer.markdown (3)
17-21
: Eliminate duplicated introduction content.The first paragraph (lines 17–19) and the second paragraph (lines 20–21) describe nearly identical functionality. Consider merging them into a single, concise introduction to avoid redundancy.
28-28
: Fix typo in step 3.The step reads “Goto the section
Access Tokens
.” For clarity and consistency, change “Goto” to “Go to”.
38-38
: Clarify open-ended note.The sentence “More platforms and features will be added in.” is incomplete. Consider updating it to something like “More platforms and features will be added in the future.”
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/portainer.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/portainer.markdown
[uncategorized] ~27-~27: Consider adding a hyphen.
Context: ...ile by clicking on your username in the top right corner and select My Account
. 3. Goto...
(TOP_LEFT_CORNER)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/portainer.markdown (1)
1-15
: Ensure front matter compliance with Home Assistant docs standards.Please verify that all YAML front matter keys (e.g.,
ha_category
,ha_release
,ha_iot_class
,ha_codeowners
,ha_domain
,ha_config_flow
,ha_platforms
,ha_integration_type
) follow the official integration documentation schema:
- Confirm singular vs. plural property names (
ha_category
vs.ha_categories
).- Check ordering conventions (e.g.,
title
→description
→ha_release
→ha_domain
→ …).- Validate that
ha_release: 0.41
correctly reflects the target Home Assistant version for this integration.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I took the liberty of shuffling things around a bit, to align the structure. Could you check if all is still correct? |
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (6)
source/_integrations/portainer.markdown (6)
17-21
: Avoid redundant introductory paragraphs
The second paragraph (lines 20–21) largely repeats the first. Consider merging or removing it to keep the introduction concise.Proposed diff:
-The Portainer API provides a way to manage Docker containers, images, networks, and volumes. It allows you to interact programmatically with your Docker host or Swarm cluster.
22-28
: Unify prerequisites list style
The bullet items use inconsistent phrasing (verb phrase vs. noun). Standardize to noun phrases for clarity, e.g.:- - have Portainer installed and a user with administrator rights on Portainer. - - an Access Token. + - A running Portainer instance with administrator privileges. + - A Portainer Access Token.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
27-27: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
29-34
: Improve step 3 punctuation
In step 3, add a comma (or break into two sentences) before “you will need it in the next steps” for readability:-3. Copy the generated Access Token and store it somewhere safe, you will need it in the next steps. +3. Copy the generated Access Token and store it somewhere safe. You will need it in the next steps.
27-27
: Remove trailing space
Line 27 has an extra trailing space, which violates MD009 (no-trailing-spaces). Please remove it.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
27-27: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
39-41
: Clarify “actively developed” note
“More platforms and features will be added in.” is incomplete. Consider:-This integration is currently being actively developed and tested. More platforms and features will be added in. +This integration is currently under active development and testing. More platforms and features will be added in the future.
52-52
: Ensure a newline at end of file
Add a blank line after the final{% include integrations/remove_device_service.md %}
to ensure POSIX-compliant end-of-file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/portainer.markdown
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/portainer.markdown
27-27: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/portainer.markdown (1)
1-15
: Front matter metadata is well defined
The integration’s metadata—including title, description, category, release, IoT class, code owners, domain, config flow, platforms, and integration type—aligns with Home Assistant documentation standards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/portainer.markdown (1)
17-21
: Description aligns with previous suggestions
The overview paragraph and the API details match the earlier proposed wording.
🧹 Nitpick comments (4)
source/_integrations/portainer.markdown (4)
22-28
: Fix trailing whitespace and polish prerequisites bullets
MarkdownLint reports a trailing space on line 27. Also, for consistency and capitalization, consider rephrasing the bullets.
Apply this diff:- - have Portainer installed and a user with administrator rights on Portainer. - - an Access Token. + - Have Portainer installed with administrator rights. + - An Access Token.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
27-27: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
37-41
: Clarify active development note
The sentence “More platforms and features will be added in.” reads awkwardly. Consider:-{% note %} -This integration is currently being actively developed and tested. More platforms and features will be added in. -{% endnote %} +{% note %} +This integration is actively developed and tested. More platforms and features will be added in the future. +{% endnote %}
43-46
: Rephrase supported device bullet for clarity
Use a colon to separate the device from its description:- - Binary sensor - for monitoring the status of Portainer services. + - Binary sensor: Monitor the status of Portainer services.
53-53
: Wrap token deletion reminder in a note
To increase visibility, wrap the suggestion in a note admonition:- After removing the integration, consider deleting the Portainer access token. + {% note %} + After removing the integration, consider deleting the Portainer access token. + {% endnote %}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/portainer.markdown
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/portainer.markdown
27-27: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (4)
source/_integrations/portainer.markdown (4)
1-15
: Metadata block follows standards
The frontmatter includes all required keys (title
,description
,ha_category
,ha_release
,ha_iot_class
,ha_codeowners
,ha_domain
,ha_config_flow
,ha_platforms
,ha_integration_type
) and aligns with Home Assistant documentation conventions.
29-33
: Prerequisites steps look good
The numbered steps and the link to the Portainer docs are clear and correct.
35-35
: Config flow include is correct
The standard{% include integrations/config_flow.md %}
directive for configuration steps is in place.
47-52
: Removal section is standard
The integration removal include is correctly referenced and matches other integration docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @erwindouna 👍
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
Summary by CodeRabbit