-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Improve docs of Android TV Remote #39821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe documentation for the Android TV Remote integration was updated to describe a new "Enable IME" configuration option and its usage. Additionally, a section detailing how to remove the integration was added. No code or public API changes were made; only documentation content was updated. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation updates. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/androidtv_remote.markdown (2)
34-35
: Hyphenate “on-screen” for grammatical correctnessUse the compound adjective “on-screen keyboard” to align with standard English usage and silence the LanguageTool warning.
- description: Needed for getting the current app name and sending text as keyboard input. Disable for devices that show 'Use keyboard on mobile device screen' instead of the on screen keyboard. + description: Needed for getting the current app name and sending text as keyboard input. Disable for devices that show 'Use keyboard on mobile device screen' instead of the on-screen keyboard.
575-579
: Remove superfluous blank line to satisfy MD012
markdownlint
flags two consecutive blank lines after the remove device service include. Delete the extra line to restore single-blank-line spacing.{% include integrations/remove_device_service.md %} -
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/androidtv_remote.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/androidtv_remote.markdown
[uncategorized] ~35-~35: The adjective “on-screen” is spelled with a hyphen.
Context: ...on mobile device screen' instead of the on screen keyboard. {% endconfiguration_basic %} ...
(ON_SITE_HYPHEN)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/androidtv_remote.markdown
579-579: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions. Thank you, @tronikos 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/androidtv_remote.markdown (2)
34-35
: Quote the literal text to avoid YAML/parser issues & improve readability
The description mixes single quotes inside an un-quoted string ('Use keyboard on mobile device screen'
). Some of our generators interpret this block as YAML and may choke on the unescaped'
. Wrapping the entire description in double quotes (or escaping the inner quotes) prevents surprises and keeps the rendered docs identical.- description: Enable this option to be able to get the current app name and send text as keyboard input. Disable it for devices that show 'Use keyboard on mobile device screen' instead of the on-screen keyboard. + description: "Enable this option to be able to get the current app name and send text as keyboard input. Disable it for devices that show 'Use keyboard on mobile device screen' instead of the on-screen keyboard."
586-587
: Remove the extra blank line flagged by markdownlint (MD012)
Two consecutive blank lines create a lint error and break the otherwise tight layout.- -
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/androidtv_remote.markdown
(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/androidtv_remote.markdown
587-587: Multiple consecutive blank lines
Expected: 1; Actual: 2
(MD012, no-multiple-blanks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/androidtv_remote.markdown (1)
588-590
: Removal section correctly placed – thanks for addressing prior feedback
The new “Removing the integration” section is now at the end of the page, matching lifecycle order and past review comments. Looks good.
Proposed change
Add some missing parts to make the integration platinum again.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit