-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Z-Wave backup: device is no longer reset during backup #39823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Z-Wave JS integration documentation to reflect that the backup process no longer factory resets the adapter.
- Removed mention of factory reset from the Info note
- Adjusted wording to describe only the backup action without implying device reset
Comments suppressed due to low confidence (2)
source/_integrations/zwave_js.markdown:192
- Since the backup no longer resets the adapter, consider updating this prompt to something like "To confirm the backup, select Submit." to avoid confusion.
- To confirm device reset, select **Submit**.
source/_integrations/zwave_js.markdown:193
- The second sentence still indicates that stored network information is removed, which was part of the reset. If the adapter is not being reset, remove or rephrase this sentence to accurately describe what happens after backup.
- **Info**: This will initiate a backup of the network information. All the stored network information will be removed.
📝 WalkthroughWalkthroughThe documentation for migrating a Z-Wave network to a new adapter was updated to remove the explicit reference to performing a factory reset during the migration process. The revised text now only mentions backing up and removing stored network information, without specifying a factory reset. Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to documentation text clarification. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/zwave_js.markdown
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
@@ -190,7 +190,7 @@ Do this if you have an existing Z-Wave network and want to use a new adapter. Th | |||
4. Select **Migrate to a new adapter**. | |||
|
|||
- To confirm device reset, select **Submit**. | |||
- **Info**: This will initiate a backup of the network information and factory reset the adapter. All the stored network information will be removed. | |||
- **Info**: This will initiate a backup of the network information. All the stored network information will be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't remove the stored network information from the old adapter.
@@ -190,7 +190,7 @@ Do this if you have an existing Z-Wave network and want to use a new adapter. Th | |||
4. Select **Migrate to a new adapter**. | |||
|
|||
- To confirm device reset, select **Submit**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't reset the adapter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, duh. Thank you for the catch. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration description paragraph in the beginning of the section needs to be updated too.
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit