-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add price indices service to Nord Pool #39869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds documentation for the new Nord Pool service that retrieves price data for a specific date.
- Introduces the Get price indices for date section with service details.
- Specifies configuration options, usage notes, and a YAML example.
- Provides notes and tips about API limitations and getting the config entry.
Comments suppressed due to low confidence (2)
source/_integrations/nordpool.markdown:167
- The heading refers to "price indices" but the example service is
nordpool.get_prices_for_date
. Consider renaming the heading to "Get prices for date" or aligning the service name with "indices".
### Get price indices for date
source/_integrations/nordpool.markdown:204
- [nitpick] Consider adding an example of the expected response payload for this service so users know what data structure to expect.
```yaml
📝 WalkthroughWalkthroughA new documentation section was added to the Nord Pool integration, detailing how to retrieve price indices for a specific date. The section explains parameters, API limitations, and provides an example YAML action for the new "get_prices_for_date" capability. No code or public entity changes were made. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NordPool Integration
User->>NordPool Integration: Call "get_prices_for_date" action (with date, areas, currency, resolution)
NordPool Integration-->>User: Return price indices for the specified date and parameters
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
source/_integrations/nordpool.markdown (3)
171-172
: Add missing commas to improve readability.The current sentence is hard to parse. A couple of commas solve it.
-The areas, currency and resolution parameters are optional. If omitted, the values configured in the integration will be used and for resolution it will default to 60 minutes. +The areas, currency, and resolution parameters are optional. If omitted, the values configured in the integration will be used, and for resolution it will default to 60 minutes.
173-184
: Clarify “Resolution” parameter (units & examples).Readers may not know what values are valid for resolution. Consider spelling out the unit (minutes) and giving concrete examples.
-Resolution: - description: Resolution time for price indices. +Resolution (minutes): + description: Desired time resolution, expressed in minutes (e.g., 60 for hourly, 15 for quarter-hourly).
186-194
: Minor grammar fix (“returned as UTC”) & duplicate note.
- “returned in UTC” → “returned as UTC” (usual collocation).
- This entire note block is identical to the one above (lines 136-144).
Re-using the same include/partial would avoid duplication drift.-Although Nord Pool operates in the CET/CEST timezone, all data is returned in UTC. +Although Nord Pool operates in the CET/CEST timezone, all data is returned as UTC timestamps.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/nordpool.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/nordpool.markdown
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ne market area to create output for. If omitted it will use the areas from the configur...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~181-~181: A comma might be missing here.
Context: ... base currency in Nord Pool prices. If omitted it will use the currency from the confi...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[grammar] ~190-~190: The usual collocation for “returned” is “to”, not “in”.
Context: ...s in the CET/CEST timezone, all data is returned in UTC. Depending on how the data is consu...
(RETURN_IN_THE)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/nordpool.markdown (1)
204-213
: Example still calls the wrong action & omitsresolution
Same issue noted in the previous review: the example references
nordpool.get_prices_for_date
, but this section documents price indices, and the YAML is missing theresolution
parameter.-action: nordpool.get_prices_for_date +action: nordpool.get_price_indices_for_date ... currency: SEK + resolution: 15 # minutes – adjust as needed
🧹 Nitpick comments (2)
source/_integrations/nordpool.markdown (2)
171-172
: Add commas & tighten wording for optional-parameter noteCurrent phrasing is a bit hard to parse; a small punctuation tweak improves readability.
-The areas, currency, and resolution parameters are optional. If omitted, the values configured in the integration will be used and for resolution it will default to 60 minutes. +The areas, currency, and resolution parameters are optional. If omitted, the integration’s configured values are used, and the resolution defaults to 60 minutes.
182-184
: Clarify units for the Resolution fieldThe description doesn’t indicate the unit (minutes). Explicitly stating this avoids confusion.
-Resolution: - description: Resolution time for price indices. +Resolution: + description: Resolution time in minutes for the price indices (defaults to 60).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/nordpool.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/nordpool.markdown
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ne market area to create output for. If omitted it will use the areas from the configur...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~181-~181: A comma might be missing here.
Context: ... base currency in Nord Pool prices. If omitted it will use the currency from the confi...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[grammar] ~190-~190: The usual collocation for “returned” is “to”, not “in”.
Context: ...s in the CET/CEST timezone, all data is returned in UTC. Depending on how the data is consu...
(RETURN_IN_THE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @gjohansson-ST 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/nordpool.markdown (1)
205-213
: Example calls wrong action & omitsresolution
Same issue flagged in the previous review: the example is still using the price sensor action instead of the new indices action and does not show the optional
resolution
parameter. This will confuse users.action: nordpool.get_prices_for_date +# Should be: +# action: nordpool.get_price_indices_for_date @@ currency: SEK + resolution: 15 # minutes – adjust as needed
🧹 Nitpick comments (2)
source/_integrations/nordpool.markdown (2)
179-181
: Comma missing after introductory clauseInsert a comma after “omitted” for smoother readability and to match earlier sentences.
- description: Select one market area to create output for. If omitted it will use the areas from the configuration entry. + description: Select one market area to create output for. If omitted, it will use the areas from the configuration entry.
182-184
: Clarify resolution unitsReaders may not know what unit “Resolution” expects. Add “in minutes” (or the correct unit) to avoid ambiguity.
-Resolution: - description: Resolution time for price indices. +Resolution: + description: Resolution time (in minutes) for price indices.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
source/_integrations/nordpool.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/nordpool.markdown
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ne market area to create output for. If omitted it will use the areas from the configur...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[grammar] ~190-~190: The usual collocation for “returned” is “to”, not “in”.
Context: ...s in the CET/CEST timezone, all data is returned in UTC. Depending on how the data is consu...
(RETURN_IN_THE)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Proposed change
Adds price indices service to Nord Pool
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit