-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Remote control updates #3997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote control updates #3997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could keep the long example but mark it as advanced? I'm ok with removing it though.
I know it feels bad to remove a big chunk of work but in this context I find it confusing. I believe the platform documentation should explain the platform and not teach how to combine things, we have other resources for that. I considered moving it to the Cookbook but there are already similar examples, for example here. |
|
||
| Service data attribute | Optional | Description | | ||
| ---------------------- | -------- | ----------- | | ||
| `entity_id` | yes | Only act on specific remote. Else targets all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing determiner: on a specific remote
Use comma: remote, else target all
|
||
| Service data attribute | Optional | Description | | ||
| ---------------------- | -------- | ----------- | | ||
| `entity_id` | yes | Only act on specific remote. Else targets all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing determiner: on a specific remote
Use comma: remote, else target all
|
||
| Service data attribute | Optional | Description | | ||
| ---------------------- | -------- | ----------- | | ||
| `entity_id` | yes | Only act on specific remote. Else targets all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing determiner: on a specific remote
Use comma: remote, else target all
| Service data attribute | Optional | Description | | ||
| ---------------------- | -------- | ----------- | | ||
| `entity_id` | yes | Only act on specific remote. Else targets all. | ||
| `device` | no | Device ID to send command to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing determiner: to send the command to
|
||
| Service data attribute | Optional | Description | | ||
| ---------------------- | -------- | ----------- | | ||
| `entity_id` | yes | Only act on specific remote. Else targets all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing determiner: on a specific remote
Use comma: remote, else target all
@amelchio Reviewed your PR and found a couple of tiny spelling/grammar things. Could you please take a look? |
@frenck Thanks. I fixed those now, also in the component doc where I had copied it from :) |
@amelchio Even better! Thank you for this 🏅 |
Description:
sync
(moved to Harmony) anddevice
(is now optional) from remote, remote.apple_tv and remote.itach.Checklist:
current
. New documentation for platforms/components and features should go tonext
.